Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Plugin#ConfigOptions: Remove placeholder and use default instead #142

Merged
merged 1 commit into from
Jan 2, 2024
Merged

Plugin#ConfigOptions: Remove placeholder and use default instead #142

merged 1 commit into from
Jan 2, 2024

Conversation

sukhwinder33445
Copy link
Contributor

No description provided.

@sukhwinder33445 sukhwinder33445 self-assigned this Dec 12, 2023
@cla-bot cla-bot bot added the cla/signed CLA is signed by all contributors of a PR label Dec 12, 2023
@sukhwinder33445 sukhwinder33445 mentioned this pull request Dec 13, 2023
Merged
nilmerg added a commit to Icinga/icinga-notifications-web that referenced this pull request Dec 19, 2023
@nilmerg
Use available_channel_type table data to create channelForm (#143)
8506590 
## Requires:

- Icinga/icinga-notifications#108
- Icinga/icinga-notifications#142
julianbrost
julianbrost approved these changes Jan 2, 2024
View reviewed changes
Copy link
Collaborator

@julianbrost julianbrost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMHO somewhat strange to not distinguish between the two, but if web wants it that way, fine fore me.

@julianbrost julianbrost merged commit 0d6f727 into main Jan 2, 2024
4 checks passed
@julianbrost julianbrost deleted the fix/channel-config-options branch January 2, 2024 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@julianbrost julianbrost julianbrost approved these changes

Assignees

@sukhwinder33445 sukhwinder33445

Labels
cla/signed CLA is signed by all contributors of a PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sukhwinder33445 @julianbrost