Use available_channel_type table data to create channelForm
#143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sukhwinder33445
force-pushed
the
create-channel-form-using-plugin-table
branch
5 times, most recently
from
370f7fd
to
f44f842
Compare
sukhwinder33445
force-pushed
the
create-channel-form-using-plugin-table
branch
from
f44f842
to
6c3c99a
Compare
sukhwinder33445
force-pushed
the
create-channel-form-using-plugin-table
branch
2 times, most recently
from
e3c607e
to
bc26fa9
Compare
sukhwinder33445
changed the title
available_channel_type table data to create channelForm
sukhwinder33445
force-pushed
the
create-channel-form-using-plugin-table
branch
3 times, most recently
from
f97ad40
to
c3cf9ae
Compare
sukhwinder33445
force-pushed
the
create-channel-form-using-plugin-table
branch
2 times, most recently
from
1eb205c
to
762856e
Compare
sukhwinder33445
force-pushed
the
create-channel-form-using-plugin-table
branch
2 times, most recently
from
37fd34c
to
c277075
Compare
nilmerg
requested changes
Nov 28, 2023
sukhwinder33445
force-pushed
the
create-channel-form-using-plugin-table
branch
from
c277075
to
d4ede65
Compare
nilmerg
requested changes
Nov 29, 2023
sukhwinder33445
force-pushed
the
create-channel-form-using-plugin-table
branch
from
6377689
to
ecdf7bd
Compare
- A channel plugin now defines required config elements and insert them into plugin table's `config_attrs` column as json
As the plugins provide there own config elements, hardcoded check for rocketchat and email isn't ideal. But exceptionally, the email check remains as it is the most used at the moment.
Multiple channels can be defined with same type, so the channel name is more relevant.
sukhwinder33445
force-pushed
the
create-channel-form-using-plugin-table
branch
2 times, most recently
from
063dca4
to
ece0dc2
Compare
sukhwinder33445
force-pushed
the
create-channel-form-using-plugin-table
branch
from
ece0dc2
to
26601ae
Compare
nilmerg
requested changes
Dec 13, 2023
Remove class locale property
nilmerg
approved these changes
Dec 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requires: