Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add: Update GoodID and claim flow #128
base: master
Are you sure you want to change the base?
Add: Update GoodID and claim flow #128
Changes from 65 commits
6306783
395fc47
e514376
eaec88e
3713ae5
2b492fa
7c03881
681a6dd
eeebaa0
4939576
f050787
05beb0f
6b2e78e
0d1bb39
38dfe5a
3922e30
7193179
8b322ef
3c97722
c752b38
5f9925c
5265c8a
23e64cd
397fabc
51d034d
bddc880
6fc954a
7c53df7
26e1ea0
a4e4869
d4c5fa0
cd6a12e
db41581
f9969ad
4071a47
c241aee
bc0b729
833572e
83d1935
c65ed8e
c113083
072faa2
e92d61e
a0d1b07
81e9236
ef3d45e
86a8cee
ce8aac6
71f4835
054ca0b
ad7d86e
239667e
095a36f
fa333cf
7631248
d7a00e6
efea670
12a766c
dbe713b
a5fd111
dd8ebb5
3a778e2
9c05cd6
efda7af
fc9ba26
1264168
813b5f1
5ff8bdb
349c906
2c55f4c
c3f844b
5730cb5
c7ba600
f8f20a4
c4682c7
46e3b1e
245950a
201d7d7
04a2c90
2a595b9
954e157
83c0986
916d09c
36c2495
55a9746
f0fc9a1
ba2fadc
ba70dfa
e183c80
c5783e2
6889de2
329d88b
c1a238f
8e467cd
75b0cce
80712d0
dd05238
5779254
a82516e
957e3e0
fa7b854
16b891c
0b9bebc
4bd6bec
e637626
abb32d9
62e07ae
fa18582
3cd8d0f
f604325
c5b1daf
c81c523
6e632f1
bfa74e5
7b8a2c2
b7ddd6f
9fb694c
57c1029
ac2b3a4
1fdee33
b6b260b
603d9eb
4ea5e45
0e451dc
49c2374
c67e7f2
9d904e3
8601384
2276411
7f5594e
5a76e06
81fd194
23e3f37
6be4b57
d33b053
9e36268
f927508
96091f1
a2b0641
de52836
a841f10
df61635
4fedc7c
1f4f6b8
1985097
2319fac
d00dd87
4359bf7
57b3853
2b4699b
085355e
64fceb7
e289c69
4297c67
844d8ce
152159e
c5e9b1f
c22a5b9
4803d2b
d4ddc54
005e91b
49b9ce0
86e77e1
f993e4c
91555be
df1e8f0
a3a39d2
ec58ee2
899dd95
d8ba27b
0e703b2
460739e
f2e0636
783b394
db91ac2
03a153f
6bdc3f9
fb2fd61
47071d6
ee46d53
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
and you do not need it. you have all 4 types, you just put type from item to the CardRowItem and display corresponding data.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@L03TJ3 one of certificates is the same for 3 types, but in result collection it will have 3 items having different type
so you display it 3 times but with passing different type to the row item component which will display different label & data
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@johnsmith-gooddollar I don't need them all 4.
What we need is the values of the 'Age, Gender, Location' certificates.
so in any way there is a filter needed. Either I filter out the identity certificate and use the remaining three. Or it's like I have done and use the identity certificate to get the gender and location
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@L03TJ3 you just go over all certificates from useAggregated, you skip Identity Type and you display the value which corresponds the type. Please fix it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if it doesn't clear we could discuss tomorrow at sync
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this should be part of CardRowItem. depending of type you pick up different values from subject and display them the different way