-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add: Update GoodID and claim flow #128
base: master
Are you sure you want to change the base?
Conversation
…-credential-storage
…-credential-storage
…-credential-storage
- removed bad practice catching transactions (should be handled by caller) - update type definition
certificates.db.zip |
@johnsmith-gooddollar @sirpy I want you guys to come to an agreement before I change anything else. What I had was nothing more then a single table: Per type of: 'localtion', 'identity', 'age', 'gender' imo, super simple. I am not sure what is expected of me to implement now |
* fix: add balancecheck to wait on faucet top-up when doing multiple claims * Dev version beta.2e1b86bf released * fix: await faucet in new claim-flow * Update packages/sdk-v2/src/sdk/claim/react.ts * Update packages/sdk-v2/src/sdk/claim/react.ts * fix: state update for awaiting signatures should be done before tx is mined * fix: use provider/signer to receive balance * chore-fix: styling, links, copy * update comment * remove unncessary checks * fix: dont run getBalance when not needed
* New translations messages.po (English) * New translations messages.po (Spanish, Latin America) * New translations messages.po (English) * New translations messages.po (Spanish, Latin America) * New translations messages.po (English) * New translations messages.po (Spanish, Latin America) * New translations messages.po (French) * New translations messages.po (Spanish) * New translations messages.po (Italian) * New translations messages.po (Korean) * New translations messages.po (Turkish) * New translations messages.po (Ukrainian) * New translations messages.po (Chinese Simplified) * New translations messages.po (Vietnamese) * New translations messages.po (Portuguese, Brazilian) * New translations messages.po (Indonesian) * New translations messages.po (Hindi) * New translations messages.po (English, United States) * New translations messages.po (English, United Kingdom) * New translations messages.po (Spanish, Latin America) * New translations messages.po (English, United Kingdom)
…b3-Mono into 116-credential-storage
* New translations messages.po (Spanish, Latin America) * New translations messages.po (French) * New translations messages.po (Spanish) * New translations messages.po (Italian) * New translations messages.po (Korean) * New translations messages.po (Turkish) * New translations messages.po (Ukrainian) * New translations messages.po (Chinese Simplified) * New translations messages.po (Vietnamese) * New translations messages.po (Portuguese, Brazilian) * New translations messages.po (Indonesian) * New translations messages.po (Hindi) * New translations messages.po (English, United Kingdom) * New translations messages.po (Spanish)
…b3-Mono into 116-credential-storage
Description
Main good-id branch. Currently statusses are:
original credential-storage pr description (Reviewed)
For the MVP of the new good-id flow we need a way to store verified credentials received from the server after completing the new flow. Verified credentials will be read from storage and displayed on the goodId card
Out of scope for this pr:
About # (link your issue here)
#116
For reviewers
This is the most basic setup for the database. any additional changes related to expected credential format, or for example the wallet db interface will be done in alternative pr's accociated to specific screens / steps in the good-id flow.
After review this branch will be turned in the main good-id PR