Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add: Update GoodID and claim flow #128

Open
wants to merge 180 commits into
base: master
Choose a base branch
from
Open

Conversation

L03TJ3
Copy link
Collaborator

@L03TJ3 L03TJ3 commented Feb 21, 2024

Description

Main good-id branch. Currently statusses are:

  • -

original credential-storage pr description (Reviewed)

For the MVP of the new good-id flow we need a way to store verified credentials received from the server after completing the new flow. Verified credentials will be read from storage and displayed on the goodId card

  • adds a local credentials db using dexie
  • adds a flow for retrieving active credentials and adding new credentials to the db
  • adds a story example
  • needs the remaining crud operations of update/delete

Out of scope for this pr:

  • Handling disputed values
  • needs a defined interface for the wallet db

About # (link your issue here)
#116

For reviewers

This is the most basic setup for the database. any additional changes related to expected credential format, or for example the wallet db interface will be done in alternative pr's accociated to specific screens / steps in the good-id flow.

After review this branch will be turned in the main good-id PR

@L03TJ3 L03TJ3 changed the title 116 credential storage GoodId Mar 5, 2024
@L03TJ3 L03TJ3 changed the title GoodId 116: Credential Storage Mar 5, 2024
@L03TJ3 L03TJ3 marked this pull request as ready for review March 5, 2024 08:00
packages/sdk-v2/src/contexts/goodid/GoodIdContext.tsx Outdated Show resolved Hide resolved
packages/sdk-v2/src/contexts/goodid/GoodIdContext.tsx Outdated Show resolved Hide resolved
packages/sdk-v2/src/contexts/goodid/GoodIdContext.tsx Outdated Show resolved Hide resolved
packages/sdk-v2/src/sdk/goodid/db/createDb.ts Outdated Show resolved Hide resolved
packages/sdk-v2/src/sdk/goodid/hooks/useCredentials.ts Outdated Show resolved Hide resolved
packages/sdk-v2/src/sdk/goodid/types.ts Outdated Show resolved Hide resolved
packages/sdk-v2/src/sdk/goodid/types.ts Outdated Show resolved Hide resolved
packages/sdk-v2/src/sdk/goodid/utils/resolverAgent.ts Outdated Show resolved Hide resolved
packages/sdk-v2/package.json Outdated Show resolved Hide resolved
packages/sdk-v2/src/sdk/goodid/db/createDb.ts Outdated Show resolved Hide resolved
packages/sdk-v2/src/sdk/goodid/hooks/useCertificates.ts Outdated Show resolved Hide resolved
packages/sdk-v2/src/sdk/goodid/hooks/useCertificates.ts Outdated Show resolved Hide resolved
@johnsmith-gooddollar
Copy link
Collaborator

certificates.db.zip
@L03TJ3 an example of data structure I want to have. use SQLite client to view it. A database view was made as an example of the query to use for pick up certificates. To add type condition you could just add AND credential = '<any of VerifiableLocationCredential | VerifiableIdentityCredential | VerifiableGenderCredential | VerifiableAgeCredential>'

@L03TJ3
Copy link
Collaborator Author

L03TJ3 commented Mar 12, 2024

@johnsmith-gooddollar @sirpy I want you guys to come to an agreement before I change anything else.

What I had was nothing more then a single table:
CredentialType, json

Per type of: 'localtion', 'identity', 'age', 'gender'

imo, super simple.

I am not sure what is expected of me to implement now

* fix: add balancecheck to wait on faucet top-up when doing multiple claims

* Dev version beta.2e1b86bf released

* fix: await faucet in new claim-flow

* Update packages/sdk-v2/src/sdk/claim/react.ts

* Update packages/sdk-v2/src/sdk/claim/react.ts

* fix: state update for awaiting signatures should be done before tx is mined

* fix: use provider/signer to receive balance

* chore-fix: styling, links, copy

* update comment

* remove unncessary checks

* fix: dont run getBalance when not needed
* New translations messages.po (English)

* New translations messages.po (Spanish, Latin America)

* New translations messages.po (English)

* New translations messages.po (Spanish, Latin America)

* New translations messages.po (English)

* New translations messages.po (Spanish, Latin America)

* New translations messages.po (French)

* New translations messages.po (Spanish)

* New translations messages.po (Italian)

* New translations messages.po (Korean)

* New translations messages.po (Turkish)

* New translations messages.po (Ukrainian)

* New translations messages.po (Chinese Simplified)

* New translations messages.po (Vietnamese)

* New translations messages.po (Portuguese, Brazilian)

* New translations messages.po (Indonesian)

* New translations messages.po (Hindi)

* New translations messages.po (English, United States)

* New translations messages.po (English, United Kingdom)

* New translations messages.po (Spanish, Latin America)

* New translations messages.po (English, United Kingdom)
- external-links should be opening new tab
- wrong env passed down to gc-sdk
- minor styling
* New translations messages.po (Spanish, Latin America)

* New translations messages.po (French)

* New translations messages.po (Spanish)

* New translations messages.po (Italian)

* New translations messages.po (Korean)

* New translations messages.po (Turkish)

* New translations messages.po (Ukrainian)

* New translations messages.po (Chinese Simplified)

* New translations messages.po (Vietnamese)

* New translations messages.po (Portuguese, Brazilian)

* New translations messages.po (Indonesian)

* New translations messages.po (Hindi)

* New translations messages.po (English, United Kingdom)

* New translations messages.po (Spanish)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants