Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation with Dokka and KDoc #537

Merged
merged 21 commits into from
Jun 20, 2024

Conversation

BasBuijsen
Copy link
Contributor

This adds the setup of Dokka. This generates HTML based on the KDoc comments provided for every function and class. For now i didn't add them yet to all the classes since that is a huge chunk of work. I will incrementally add documentation, but for now only showing the signatures should suffice.

The publishing of the generated HTML still needs to be setup. I need @nbransby for that so that is out of my control.

Since all publicly available classes and functions will be shown in the documentation, this change will also improve the documentation a lot. It will make sure that only the classes and functions that are actually exposed will be documented.

@BasBuijsen BasBuijsen mentioned this pull request Jun 16, 2024
@nbransby
Copy link
Member

@Reedyuk what do you think is the best way to publish the documentation? is there a GitHub Action we can use to publish the dokka output to github pages?

@BasBuijsen do you have experience with publishing to GitHub pages?

@nbransby
Copy link
Member

@BasBuijsen build failed due to the function you made internal that are needed by inline functions (can use @PublishedApi here)

@BasBuijsen
Copy link
Contributor Author

@nbransby i dont have experience with publishing to github pages but from what ive seen it is very easy. There is a ready to go action that will do all the magic if you set the environment variables correctly, so i think that would be the easiest and probably cheapest solution (there is one website free per gh organisation or user).

I will fix the JS build this afternoon, after work :)

@Reedyuk
Copy link
Collaborator

Reedyuk commented Jun 17, 2024

@BasBuijsen
Copy link
Contributor Author

@Reedyuk thanks for adding the deployment steps!

Ive added documentation for nearly all modules now. Only authentication, analytics and firestore are left to do.

@Reedyuk
Copy link
Collaborator

Reedyuk commented Jun 18, 2024

I think rebase didnt work correctly, as its not compiling on the github servers.

@BasBuijsen
Copy link
Contributor Author

I think rebase didnt work correctly, as its not compiling on the github servers.

Yes i made a mistake while resolving the merge conflict. Will fix it :)

@Reedyuk
Copy link
Collaborator

Reedyuk commented Jun 18, 2024

I think rebase didnt work correctly, as its not compiling on the github servers.

Yes i made a mistake while resolving the merge conflict. Will fix it :)

get this building on the ci and i will merge in and make sure the docs deploy correctly.

@Reedyuk
Copy link
Collaborator

Reedyuk commented Jun 19, 2024

@BasBuijsen - can you rebase this pull request please

@BasBuijsen
Copy link
Contributor Author

@nbransby or @Reedyuk would it be okay to merge this pr now?

I will add comments to Auth and Firestore next week. Analytics is difficult because it doesn't have an open source codebase so i cant really copy the comments.

@BasBuijsen
Copy link
Contributor Author

@Reedyuk when its deployed can you send me the url so i can add it to the readme when i create a new pr with the final documentation changes next week?

@Reedyuk Reedyuk merged commit 0376989 into GitLiveApp:master Jun 20, 2024
13 checks passed
@BasBuijsen BasBuijsen deleted the feat/Documentation branch June 20, 2024 08:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants