-
Notifications
You must be signed in to change notification settings - Fork 160
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Firestore: Insufficient documentation. #622
Comments
The general rule of thumb is to map it closely the Android sdk, you can see the google docs here: https://firebase.google.com/docs/reference/kotlin/packages Remember this library is just a wrapper of the current implementation, we are not re-inventing the wheel, just trying to unify things. |
@Reedyuk I understand that. But still some functions and parameters changed. If it is 1 to 1 implementation - comments could be just copied from the source. I believe a user of the library should be able to see the documentation directly on the the functionality and not spend additional time to search it separately. |
Happy for you to open a PR and we can review it. |
The current documentation was kindly contributed by @BasBuijsen here #537 Definitely agree the relevant documentation should just be copied from the android documentation but as mentioned in the PR its a large piece of work that has yet to be contributed. |
Hi.
There is not enough documentation for Firestore. Even in KDoc there are almost no comments on functions explaining what each function or argument does, and what the function's result is.
Please cover all functionality with documentation.
The text was updated successfully, but these errors were encountered: