-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ENHANCEMENT] Better mod support for stickers (StickerRegistry) #4003
Open
AbnormalPoof
wants to merge
11
commits into
FunkinCrew:develop
Choose a base branch
from
AbnormalPoof:feat/modded-sticker-packs
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
[ENHANCEMENT] Better mod support for stickers (StickerRegistry) #4003
AbnormalPoof
wants to merge
11
commits into
FunkinCrew:develop
from
AbnormalPoof:feat/modded-sticker-packs
+281
−80
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
haxe
Issue/PR modifies game code
documentation
Issue/PR modifies documentation or README files
large
A large pull request with more than 100 changes
labels
Jan 15, 2025
This was referenced Jan 15, 2025
Oh, this is nice! Good work! |
I like how this standardizes the stickers to match how the rest of the game uses data. However, this PR has merge conflicts with v0.6 (it utilizes the previously unused sticker pack system). We can resolve those at that point. |
EliteMasterEric
added
status: planned
This suggestion/enhancement is planned to be implemented some time in the future.
type: enhancement
Provides an enhancement or new feature.
labels
Jan 16, 2025
EliteMasterEric
added
status: planned
This suggestion/enhancement is planned to be implemented some time in the future.
and removed
status: planned
This suggestion/enhancement is planned to be implemented some time in the future.
labels
Jan 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
documentation
Issue/PR modifies documentation or README files
haxe
Issue/PR modifies game code
large
A large pull request with more than 100 changes
status: planned
This suggestion/enhancement is planned to be implemented some time in the future.
type: enhancement
Provides an enhancement or new feature.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Does this PR close any issues? If so, link them below.
Implements #3969
Briefly describe the issue(s) fixed.
This PR moves sticker sets to its own registry called
StickerRegistry
, and replaces the old(and quite frankly crude)StickerInfo
class with a new class calledStickerSet
. This should hopefully streamline the process of making custom sticker sets, since mods no longer need to directly replacestickers-set-1
or use JSON patching.Notes
data/stickersets
(andStickerInfo
being removed). But that's up to Eric to decide.stickers-set-1
: Movestickers-set-1
todata/stickersets/
funkin.assets#109StickerSprite
now takes a file path instead of sticker set and sticker names to support custom file paths for sticker sets.