Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement: Allow modders to easily add new transition stickers with custom set(s) #3969

Open
2 tasks done
ChillyBeanBAM opened this issue Jan 2, 2025 · 4 comments
Open
2 tasks done
Assignees
Labels
status: planned This suggestion/enhancement is planned to be implemented some time in the future. type: enhancement Provides an enhancement or new feature.

Comments

@ChillyBeanBAM
Copy link

ChillyBeanBAM commented Jan 2, 2025

Issue Checklist

  • I have properly named my enhancement
  • I have checked the Issues/Discussions pages to see if my enhancement has already been suggested

What is your suggestion, and why should it be implemented?

I've been working on a mod lately, and when I tried to add some placeholder stickers from a custom sticker set, I noticed that, even after leaving "Tutorial" and watching the transition carefully multiple times in a row, they weren't appearing. I looked into source/funkin/ui/transition/StickerSubState.hx and noticed this on line 158:

var stickerInfo:StickerInfo = new StickerInfo('stickers-set-1');

Apparently, it only reads and uses that sticker set during the transition. I propose that the code should be updated to read any sticker set in some way, including modded ones. Thank you in advance.

@ChillyBeanBAM ChillyBeanBAM added status: pending triage The bug or PR has not been reviewed yet. type: enhancement Provides an enhancement or new feature. labels Jan 2, 2025
@ChillyBeanBAM ChillyBeanBAM changed the title Enhancement: Allow mods to add custom transition stickers Enhancement: Allow mods to properly add transition stickers with a custom set Jan 2, 2025
@ChillyBeanBAM ChillyBeanBAM changed the title Enhancement: Allow mods to properly add transition stickers with a custom set Enhancement: Allow modders to easily add transition stickers with custom sets Jan 2, 2025
@ChillyBeanBAM ChillyBeanBAM changed the title Enhancement: Allow modders to easily add transition stickers with custom sets Enhancement: Allow modders to easily add new transition stickers with custom set(s) Jan 2, 2025
@AbnormalPoof
Copy link
Contributor

AbnormalPoof commented Jan 11, 2025

For now you can use JSON Patch to add new stickers to stickers-set-1 without overriding existing stickers: https://funkincrew.github.io/funkin-modding-docs/10-appending-and-merging-files/10-02-merging-files.html

Though, not many people know this, so most sticker pack mods just directly replace stickers-set-1.

@EliteMasterEric EliteMasterEric added status: planned This suggestion/enhancement is planned to be implemented some time in the future. and removed status: pending triage The bug or PR has not been reviewed yet. labels Jan 11, 2025
@EliteMasterEric EliteMasterEric self-assigned this Jan 11, 2025
@EliteMasterEric
Copy link
Member

This feature is planned.

@AbnormalPoof
Copy link
Contributor

#4003 implements this.

@Hundrec
Copy link
Contributor

Hundrec commented Jan 16, 2025

AbnormalPoof is on it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: planned This suggestion/enhancement is planned to be implemented some time in the future. type: enhancement Provides an enhancement or new feature.
Projects
None yet
Development

No branches or pull requests

4 participants