[BUGFIX] Disable input in CharSelect until stayFunky plays #3355
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EliteMasterEric
added
the
status: pending triage
EliteMasterEric
added
type: major bug
|
|
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Does this PR close any issues? If so, link them below.
#3156
Briefly describe the issue(s) fixed.
This PR introduces a new allowInput boolean to CharSelectSubState, false by default and is only set to true when we start playing stayFunky. This prevents the game from being able to run/cancel tweens on a currently null object, being FlxG.sound.music.
Include any relevant screenshots or videos.
Before
2024-09-17_15-49-58_Funkin.mp4
After
2024-09-17_15-52-51_Funkin.mp4