[BUGFIX] Stop input spam on character select #3398
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is this a duplicate of #3355? |
Afaik no, that PR seems to block any inputs until the music starts playing. My PR sets the spam variables to false when a character is selected |
EliteMasterEric
added
the
status: pending triage
ACrazyTown
changed the title
ninjamuffin99
force-pushed
the
fix/charselect-spam-hold
branch
from
ef6a171 to
2586073
Compare
ninjamuffin99
force-pushed
the
fix/charselect-spam-hold
branch
from
2586073 to
435939a
Compare
|
thank you very much :) |
EliteMasterEric
added
type: minor bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Does this PR close any issues? If so, link them below.
None as far as I know?
Briefly describe the issue(s) fixed.
Currently if you hold a key down and press enter on a character in the character select screen, the hold won't stop and the cursor will keep moving.
In some cases this can lead to the current character to be set to an invalid value and the game will crash.
Include any relevant screenshots or videos.
8mb.video-jkb-Aa2vrZFM.mp4