-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bugfix: Produce correct receipts with debugger breakpoints enabled #889
Open
Dentosal
wants to merge
7
commits into
master
Choose a base branch
from
dento/debugger-receipts-fix
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
e1afa65
Produce correct receipts with debugger
Dentosal b394ae0
Add changelog entry
Dentosal 2d1ccbf
Add a test case
Dentosal 49a369f
fmt
Dentosal 70f8aee
Fix no-std build
Dentosal 8dc4746
fmt
Dentosal 43eb581
Fix paths
Dentosal File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. These changes are unrelated, but the CI wont pass without them. The import would have to be moved behind a feature, but I found it cleaner to just inline them. |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,72 @@ | ||
use alloc::{ | ||
vec, | ||
vec::Vec, | ||
}; | ||
|
||
use fuel_asm::{ | ||
op, | ||
RegId, | ||
}; | ||
use fuel_tx::{ | ||
ConsensusParameters, | ||
Finalizable, | ||
GasCosts, | ||
Script, | ||
TransactionBuilder, | ||
}; | ||
|
||
use crate::{ | ||
prelude::{ | ||
Interpreter, | ||
IntoChecked, | ||
}, | ||
state::ProgramState, | ||
}; | ||
|
||
#[test] | ||
fn receipts_are_produced_correctly_with_stepping() { | ||
let script = vec![ | ||
op::movi(0x20, 1234), | ||
op::log(0x20, RegId::ZERO, RegId::ZERO, RegId::ZERO), | ||
AurelienFT marked this conversation as resolved.
Show resolved
Hide resolved
|
||
op::ret(RegId::ONE), | ||
] | ||
.into_iter() | ||
.collect(); | ||
|
||
let params = ConsensusParameters::standard(); | ||
let tx = TransactionBuilder::script(script, Vec::new()) | ||
.script_gas_limit(1_000_000) | ||
.maturity(Default::default()) | ||
.add_fee_input() | ||
.finalize() | ||
.into_checked(Default::default(), ¶ms) | ||
.expect("failed to check tx") | ||
.into_ready(0, &GasCosts::default(), params.fee_params(), None) | ||
.expect("failed to ready tx"); | ||
|
||
let mut vm = Interpreter::<_, _, Script>::with_memory_storage(); | ||
vm.transact(tx.clone()).expect("panicked"); | ||
let receipts_without_debugger = vm.receipts().to_vec(); | ||
|
||
let mut vm = Interpreter::<_, _, Script>::with_memory_storage(); | ||
vm.set_single_stepping(true); | ||
let mut t = *vm.transact(tx).expect("panicked").state(); | ||
loop { | ||
match t { | ||
ProgramState::Return(_) | ||
| ProgramState::ReturnData(_) | ||
| ProgramState::Revert(_) => { | ||
break; | ||
} | ||
ProgramState::RunProgram(_) => { | ||
t = vm.resume().expect("panicked"); | ||
} | ||
ProgramState::VerifyPredicate(_) => { | ||
unreachable!("no predicates in this test") | ||
} | ||
} | ||
} | ||
let receipts_with_debugger = vm.receipts(); | ||
|
||
assert_eq!(receipts_without_debugger, receipts_with_debugger); | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I know this is not introduced in this PR so it's not blocking, but do we have an issue for this?