bugfix: Produce correct receipts with debugger breakpoints enabled #889
+170
−99
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dentosal
added
bug
Dentosal
changed the title
Dentosal
changed the title
Dentosal
requested review from
xgreenx,
MitchTurner and
Voxelot
as code owners
Dentosal
commented
Jan 16, 2025
There was a problem hiding this comment.
These changes are unrelated, but the CI wont pass without them. The import would have to be moved behind a feature, but I found it cleaner to just inline them.
AurelienFT
approved these changes
Jan 16, 2025
netrome
approved these changes
Jan 16, 2025
| ProgramState::Return(return_val), | ||
| ) | ||
| } else { | ||
| // TODO set tree balance |
There was a problem hiding this comment.
I know this is not introduced in this PR so it's not blocking, but do we have an issue for this?
xgreenx
approved these changes
Jan 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While working on execution traces, I noticed that the receipts are produced in incorrect oder when the debugger is enabled. The PR moves the end-of-execution receipt generation to
run_program, so it's also done when called usingInterpreter::resume.This is technically a breaking change, but it's a bugfix so it doesn't necessarily warrant a breakng-version bump.
Checklist
Before requesting review