fix: resolves unneeded todos

Figedi · Jul 23, 2023 · 500ace0 · 500ace0
1 parent 1e50be5
commit 500ace0
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 3 deletions.
diff --git a/src/app/ApplicationBuilder.ts b/src/app/ApplicationBuilder.ts
@@ -115,7 +115,7 @@ const $env: EnvalidTransformer = {
     url,
     json,
     file,
-    any: env, // @todo resolve legacy naming
+    any: env,
     ref,
 };
 
@@ -491,7 +491,7 @@ export class ApplicationBuilder<Config> {
             return;
         }
         const baseArgs = command.info.argv({
-            $arg: <O extends AllOptions>(opts: O) => ({ ...(opts as any), __type: "opt" } as InferredOptionType<O>),
+            $arg: <O extends AllOptions>(opts: O) => ({ ...(opts as any), __type: "opt" }) as InferredOptionType<O>,
         }) as Record<string, AllOptions>;
 
         const isArgvType = (v: any) => "__type" in v && v.__type === "opt";

diff --git a/src/app/types/args.ts b/src/app/types/args.ts
@@ -48,7 +48,6 @@ type IsUnknown<T> = IsAny<T> extends true ? false : unknown extends T ? true : f
 
 type IsRequiredOrHasDefault<O extends AllOptions> = O extends { required: true } ? true : false;
 
-// @todo there is only type, alias, default, not required, thus everything is optional, aaaaaaaaarg
 export type InferredOptionType<O extends AllOptions> =
     // Handle special cases first