Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mocking Migration to NSubstitute #241

Closed
wants to merge 3 commits into from

Conversation

kdankert
Copy link
Member

Fixes #190

@kdankert kdankert linked an issue Feb 25, 2024 that may be closed by this pull request
@kdankert kdankert self-assigned this Feb 25, 2024
Copy link

@kdankert kdankert marked this pull request as ready for review February 26, 2024 10:28
@AtomicLiquid AtomicLiquid requested a review from snixtho February 26, 2024 14:12
@snixtho
Copy link
Member

snixtho commented Feb 26, 2024

Thing is, I'm not sure if we really need to do this anymore because moq reverted the changes after backlash.

@kdankert
Copy link
Member Author

Couldn't really figure out if they only deployed a temporary fix due to incompatibilties on Mac machines or if they actually tweaked SponsorLink to be gdpr compliant. I had lots of the changes locally already and decided to to push them anyways, so that we could decide whether to incorporate them or not, basicly deciding which mocking framework to use. Personally, I would still prefer moq due to their explicit wrapper objects and the reason that NSubstitute automatically defines nested mocks, which produced some unexpected behavior.

@snixtho snixtho closed this Jun 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Alternative mocking library for Moq
2 participants