Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alternative mocking library for Moq #190

Closed
snixtho opened this issue Aug 9, 2023 · 2 comments
Closed

Alternative mocking library for Moq #190

snixtho opened this issue Aug 9, 2023 · 2 comments
Assignees
Labels
core Issue or feature request related to the core code.

Comments

@snixtho
Copy link
Member

snixtho commented Aug 9, 2023

Due to recent changes in the Moq library, there are big privacy concerns, which are also violating GPDR. In short, Moq added the dependency "SponsorLink" (a closed source library) which harvests email addresses from git logs and sends them to a privately-owned cloud service. This is an automatic process that is injected and executed during build-time, and occurs without the developer's consent.

Moq is used extensively in our tests and because of this, we might need to look for alternative mocking libraries.

Some options right now are:

Due to time constraints with XPEvo, it is currently not feasable to re-write all the tests until after the event. But I created this issue so that we can discuss what to do after XPEvo.

More information about the issue can be found here: https://github.com/moq/moq/issues/1372

We are open for any suggestions on alternatives or ideas on what to do.

@snixtho snixtho added the core Issue or feature request related to the core code. label Aug 9, 2023
@kdankert
Copy link
Member

kdankert commented Aug 9, 2023

We should definetely pin the version as a quick fix and move to another framework after xpevo. https://github.com/moq/moq/issues/1372#issuecomment-1670948461 seems to restrict versions to only use versions below 4.20.

Might be https://github.com/moq/moq/issues/1372#issuecomment-1670967216 as well.

@kdankert kdankert self-assigned this Feb 25, 2024
@kdankert kdankert linked a pull request Feb 25, 2024 that will close this issue
@snixtho
Copy link
Member Author

snixtho commented Jul 31, 2024

Closing this as it is no longer a issue iirc.

@snixtho snixtho closed this as completed Jul 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Issue or feature request related to the core code.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants