Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use per ROS distro dev containers #438

Merged
merged 1 commit into from
Sep 30, 2024
Merged

Use per ROS distro dev containers #438

merged 1 commit into from
Sep 30, 2024

Conversation

hidmic
Copy link
Collaborator

@hidmic hidmic commented Sep 30, 2024

Proposed changes

Follow-up to #173. Hopefully this time around we get multi-platform development containers right.

Type of change

  • 🐛 Bugfix (change which fixes an issue)
  • 🚀 Feature (change which adds functionality)
  • 📚 Documentation (change which fixes or extends documentation)

Checklist

  • Lint and unit tests (if any) pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • All commits have been signed for DCO

@hidmic hidmic self-assigned this Sep 30, 2024
nahueespinosa
nahueespinosa approved these changes Sep 30, 2024
View reviewed changes
Copy link
Member

@nahueespinosa nahueespinosa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hidmic hidmic merged commit ac4eb10 into main Sep 30, 2024
16 checks passed
@hidmic hidmic deleted the hidmic/per-distro-dev-containers branch September 30, 2024 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nahueespinosa nahueespinosa nahueespinosa approved these changes

Assignees

@hidmic hidmic

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hidmic @nahueespinosa