Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove 'with' statement in CI workflow #414

Merged
merged 1 commit into from
Jul 16, 2024
Merged

Remove 'with' statement in CI workflow #414

merged 1 commit into from
Jul 16, 2024

Conversation

serraramiro1
Copy link
Contributor

Proposed changes

Ci pipeline is broken in master because of a with clause in the wrong step.
Why did this get through CI? @nahueespinosa FYI

Type of change

  • 🐛 Bugfix (change which fixes an issue)
  • 🚀 Feature (change which adds functionality)
  • 📚 Documentation (change which fixes or extends documentation)

Put an x in the boxes that apply. This is simply a reminder of what we will require before merging your code.

  • Lint and unit tests (if any) pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • All commits have been signed for DCO

@serraramiro1 serraramiro1 added bug Something isn't working infra Related to infrastructure and CI labels Jul 16, 2024
@nahueespinosa nahueespinosa changed the title Remove 'with' statement in CI workflow. Remove 'with' statement in CI workflow Jul 16, 2024
@serraramiro1 serraramiro1 merged commit 2200752 into main Jul 16, 2024
15 checks passed
@serraramiro1 serraramiro1 deleted the ramiro/fix-ci branch July 16, 2024 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working infra Related to infrastructure and CI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants