Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix glx error issue starting rviz in Noetic/20.04 #252

Merged
merged 1 commit into from
Aug 30, 2023
Merged

Fix glx error issue starting rviz in Noetic/20.04 #252

merged 1 commit into from
Aug 30, 2023

Conversation

glpuga
Copy link
Collaborator

@glpuga glpuga commented Aug 27, 2023 •
edited
Loading

Proposed changes

Type of change

  • 🐛 Bugfix (change which fixes an issue)
  • 🚀 Feature (change which adds functionality)
  • 📚 Documentation (change which fixes or extends documentation)

💥 Breaking change! Explain why a non-backwards compatible change is necessary or remove this line entirely if not applicable.

Checklist

Put an x in the boxes that apply. This is simply a reminder of what we will require before merging your code.

  • Lint and unit tests (if any) pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • All commits have been signed for DCO

Additional comments

Anything worth mentioning to the reviewers.

@glpuga glpuga force-pushed the glpuga/fix_ros1_rviz_glx_error branch from f8e761a to b315554 Compare August 27, 2023 21:55
@glpuga glpuga changed the title Fix glx error issue starting rviz Fix glx error issue starting rviz in Noetic/20.04 Aug 27, 2023
@glpuga glpuga marked this pull request as ready for review August 27, 2023 21:56
nahueespinosa
nahueespinosa approved these changes Aug 29, 2023
View reviewed changes
Copy link
Member

@nahueespinosa nahueespinosa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! (Tested locally)

@glpuga glpuga merged commit c0e2de1 into main Aug 30, 2023
11 checks passed
@glpuga glpuga deleted the glpuga/fix_ros1_rviz_glx_error branch August 30, 2023 20:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nahueespinosa nahueespinosa nahueespinosa approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

RViz crashes when launching the example in ROS 1
2 participants
@glpuga @nahueespinosa