i#2154 Android64: Fix write syscall in nolibc_print() #7190
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Xref musl libc having similar FILE struct issues: PR #2916 |
derekbruening
approved these changes
Jan 16, 2025
Change-Id: Icaf455801b6c3346d4a80b498407171e57db7409
Change-Id: Ib4e4828a233e0b4470c530d41404634ce3e5fa0f
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current versions of Android make the FILE struct opaque so we can't access its members to get the file descriptor for stderr. Instead we can use STDERR_FILENO from unistd.h.
Issue: #1874, #2154