I#1973: fix build on musl libc #7168
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This introduces the MUSL macro.
bits/wordsize.h is a glibc-specific header, on musl __WORD_SIZE is defined as LONG_BIT. This is okay since Linux kernel assumes the size of long is equal to a machine word.
The pre-defined config.h is adjusted to match musl's features. We also to build and link lib/error.c to provide functions for error message handling.
As DynamoRIO enables -Werror by default, such warnings will prevent a warning-aware build. Since we also issue a warnings during start up, Let's remove it.
GCC on Alpine Linux enables "-Wtrampolines" by default, breaking the test. Since Alpine is the most widely-used musl-based distribution, it's worth to work around this: let's defaults to -Wno-trampoline on musl systems.
Some glibc-specific APIs are used in the test, we need to port them to musl.
DynamoRIO defines REG_* macros for compatibility with old clients, which conflict with signal.h on musl. Use of pragma push_macro/pop_macro to avoid messing musl's header up.
|
@derekbruening thanks for your review |
If this PR is ready for review, please add a reviewer from the "Reviewers" list on the top-right1. |
I have no write access to the repository, thus cannot require a reviewer :/ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request allows DynamoRIO and all the tests to be built on musl libc,
stdout/stderr and suppress warnings for musl's opaque FILE type
actually a function call, instead of a constant value
Tested on Alpine Linux, half of the tests are passed and it's possible to run
some applications (busybox, mutt and telegram-desktop) and some simple clients
(bbsize).
Issue: #1973