Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
i#6662 public traces: update doc #7139
base: master
Are you sure you want to change the base?
i#6662 public traces: update doc #7139
Changes from 5 commits
07601ac
4d4a2ea
26e66b0
a6457e8
9b97a32
5f52afa
216fe83
b8855d3
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I assume we'd use the same bucket? Should we make version_1 and version_2 subdirs? Or just delete v1? Maybe just delete.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mhm, I'd keep version 1 in that bucket as is.
I added the deprecated section that says DynamoRIO 11.0 is the last version that will support these traces, so if somebody is still using them, they can still do so with DynamoRIO 11.0.
Can't we use a new bucket? "external_traces_v2"? Do we need a subdir?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's discuss offline.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The new one could be sthg like
console.cloud.google.com/storage/browser/external-traces-v2
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's right, I created: https://console.cloud.google.com/storage/browser/external-traces-v2 (now empty).
I've added it as link to the new public traces.
I also added a section about deprecated public v1 traces with the old link to them.
I think it might be a good idea to also have DOI for citations? We could make one with https://zenodo.org/ . This way it's easy to track who/how many cite this work.