-
Notifications
You must be signed in to change notification settings - Fork 218
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor to avoid code duplication #5220
Open
BrianMarre
wants to merge
7
commits into
ComputationalRadiationPhysics:dev
Choose a base branch
from
BrianMarre:topic-refactorToAvoidCodeCuplication
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
refactor to avoid code duplication #5220
BrianMarre
wants to merge
7
commits into
ComputationalRadiationPhysics:dev
from
BrianMarre:topic-refactorToAvoidCodeCuplication
Commits on Nov 15, 2024
-
refactor passed atomic data dataBoxes check
extracts the check for passed atomic data dataBoxes to avoid code duplication ci: picongpu
Configuration menu - View commit details
-
Copy full SHA for 4df96dc - Browse repository at this point
Copy the full SHA 4df96dcView commit details -
refactor bound-free field rate calculation
allows specifying the precision to use in the bound-free rate calculation and seperates the find maximum and minimum E-field norm in a superCell to allow reuse ci: picongpu
Configuration menu - View commit details
-
Copy full SHA for 47127be - Browse repository at this point
Copy the full SHA 47127beView commit details -
Configuration menu - View commit details
-
Copy full SHA for 2339c54 - Browse repository at this point
Copy the full SHA 2339c54View commit details -
Configuration menu - View commit details
-
Copy full SHA for d672fe7 - Browse repository at this point
Copy the full SHA d672fe7View commit details -
Configuration menu - View commit details
-
Copy full SHA for 55d3be8 - Browse repository at this point
Copy the full SHA 55d3be8View commit details -
extract reuseable SpawnFromSourceSpecies modules
refactors the ApplyIPDIonization kernel by seperating out reuseable modules for reuse ci: picongpu
Configuration menu - View commit details
-
Copy full SHA for 07f6746 - Browse repository at this point
Copy the full SHA 07f6746View commit details -
removes the code duplciation of caching the EField ci: picongpu
Configuration menu - View commit details
-
Copy full SHA for 0c9ebfe - Browse repository at this point
Copy the full SHA 0c9ebfeView commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.