refactor to avoid code duplication #5220
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Nov 14, 2024
BrianMarre
force-pushed
the
topic-refactorToAvoidCodeCuplication
branch
3 times, most recently
from
ae08efb
to
702397c
Compare
psychocoderHPC
added
component: core
extracts the check for passed atomic data dataBoxes to avoid code duplication ci: picongpu
allows specifying the precision to use in the bound-free rate calculation and seperates the find maximum and minimum E-field norm in a superCell to allow reuse ci: picongpu
refactors the ApplyIPDIonization kernel by seperating out reuseable modules for reuse ci: picongpu
removes the code duplciation of caching the EField ci: picongpu
BrianMarre
force-pushed
the
topic-refactorToAvoidCodeCuplication
branch
from
702397c
to
0c9ebfe
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is the combination of different refactors reducing code duplication in preparation for the implementation of instant field ionization transitions.
The first commit is provides the starting point, the remaining 7 commits contain one feature refactor each and are tested to compile with gcc 12.2.0 .
Please review this PR commit wise.