Fix compats, add downgrade action, remove unused dependencies #3276
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sbozzolo
force-pushed
the
gb/downgrade
branch
6 times, most recently
from
bf3d16b to
d126287
Compare
Sbozzolo
changed the title
Sbozzolo
force-pushed
the
gb/downgrade
branch
2 times, most recently
from
42e294e to
445859e
Compare
Sbozzolo
force-pushed
the
gb/downgrade
branch
2 times, most recently
from
0e9692f to
584bec1
Compare
The compats in ClimaAtmos were largely wrong. In this commit, I fix them. I also add a new action that checks that our tests pass with the oldest possible combination of packages that is advertised to be compatible with ClimaAtmos. Since we required ClimaComms 0.6, I also removed all the checks on that version for the import_required_backends
Sbozzolo
force-pushed
the
gb/downgrade
branch
from
584bec1 to
0e5db7e
Compare
Sbozzolo
requested review from
charleskawczynski,
dennisYatunin and
sriharshakandala
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The compats in ClimaAtmos were largely wrong. In this commit, I fix them. I also add a new action that checks that our tests pass with the oldest possible combination of packages that is advertised to be compatible with ClimaAtmos.
Since we required ClimaComms 0.6, I also removed all the checks on that version for the import_required_backends.
In the process, I also removed dependencies that were not required.