Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature](mluOpCholesky): add cholesky parameter #95

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

[Feature](mluOpCholesky): add cholesky parameter #95

Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
bbc5489
add cholesky parameter
dglr Apr 16, 2024
e3d8bd7
[Feature](mluOpCholesky): new parameters (#95)
Nov 18, 2024
c3fa517
[Feature](mluOpCholesky): rm temp file
Nov 18, 2024
6ebe1ab
[Feature](mluOpCholesky): modify OpType
Dec 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions mlu_op_test.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -429,6 +429,7 @@ message Node {
optional DCNParam dcn_param = 405;
optional LogcumsumexpParam logcumsumexp_param = 19980423;
optional LgammaParam lgamma_param = 202435;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

没有修改OpType
参考#105

optional CholeskyParam cholesky_param = 618323; // CholeskyParam
}


Expand Down Expand Up @@ -1191,3 +1192,9 @@ message LogcumsumexpParam {
message LgammaParam {
optional bool inplace = 1 [default = false];
}

//param to call mluOpCholesky()
message CholeskyParam {
ArtIntAI marked this conversation as resolved.
Show resolved Hide resolved
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

支持inplace需要添加类似这里的inplace参数
https://github.com/Cambricon/mlu-ops-proto/blob/master/mlu_op_test.proto#L1192

对应的要修改下generator和gtest代码

optional bool upper = 1 [default = false];
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR与远端冲突了，建议本地rebase 后再push上来

}

Loading