[Feature](mluOpCholesky): add cholesky parameter #95
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PetrelYy
reviewed
Jul 2, 2024
|
|
||
| //param to call mluOpCholesky() | ||
| message CholeskyParam { | ||
| optional bool upper = 1 [default = false]; |
There was a problem hiding this comment.
PR与远端冲突了，建议本地rebase 后再push上来
ArtIntAI
approved these changes
Nov 14, 2024
ArtIntAI
reviewed
Nov 18, 2024
ArtIntAI
reviewed
Nov 18, 2024
duzekunKTH
previously approved these changes
Nov 18, 2024
duzekunKTH
reviewed
Nov 18, 2024
temp
Outdated
| @@ -0,0 +1,1186 @@ | |||
| /************************************************************************* | |||
dglr
changed the title
ArtIntAI
reviewed
Nov 20, 2024
| @@ -429,6 +429,7 @@ message Node { | |||
| optional DCNParam dcn_param = 405; | |||
| optional LogcumsumexpParam logcumsumexp_param = 19980423; | |||
| optional LgammaParam lgamma_param = 202435; | |||
ArtIntAI
reviewed
Nov 21, 2024
| @@ -1191,3 +1192,9 @@ message LogcumsumexpParam { | |||
| message LgammaParam { | |||
| optional bool inplace = 1 [default = false]; | |||
| } | |||
|
|
|||
| //param to call mluOpCholesky() | |||
| message CholeskyParam { | |||
There was a problem hiding this comment.
支持inplace需要添加类似这里的inplace参数
https://github.com/Cambricon/mlu-ops-proto/blob/master/mlu_op_test.proto#L1192
对应的要修改下generator和gtest代码
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.