-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ability to constraint variables to binary or integer values. #14
Conversation
/format |
✔️ Auto-formatting triggered by this comment succeeded, commited as 725ed51 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #14 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 8 8
Lines 196 196
=========================================
Hits 196 196 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
a few comments, will fix/merge later
OK so, this is gonna be harder:
In the long term I suggest we remove the closed type family For the current state, I think the easiest way of supporting integer constraints is to just smash in an extra JuMP variable and an equality bound (in the end that would be the same). That should go to the tutorial. Also, we should re-think the Floatiness of the whole CTs at that point (people might just want to get integers out). |
Okay, I think opening it to integer constraints is definitely more general. |
@stelmo can you review here? edit: technically you can't for M$ reasons, pls just ack. :D |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This all looks good to me!
Allows construction of MILPs