Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make the bounds type open to extension #15

Merged
merged 2 commits into from
Dec 21, 2023
Merged

make the bounds type open to extension #15

merged 2 commits into from
Dec 21, 2023

Conversation

exaexa
Copy link
Member

@exaexa exaexa commented Dec 21, 2023

#14 should be rebased atop of this later (I can do)

@exaexa exaexa added the enhancement New feature or request label Dec 21, 2023
@exaexa exaexa requested a review from stelmo December 21, 2023 10:13
@exaexa exaexa self-assigned this Dec 21, 2023
Copy link

codecov bot commented Dec 21, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (358e3e9) 100.00% compared to head (ac52726) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##            master       #15   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            7         8    +1     
  Lines          186       196   +10     
=========================================
+ Hits           186       196   +10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@stelmo stelmo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is really great

Project.toml Outdated Show resolved Hide resolved
docs/src/metabolic-modeling.jl Show resolved Hide resolved
docs/src/metabolic-modeling.jl Show resolved Hide resolved
@exaexa exaexa merged commit 250bf55 into master Dec 21, 2023
5 checks passed
@exaexa exaexa deleted the mk-open-bounds branch June 6, 2024 07:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🖤 may unhex MILPs 🖤 hopefully enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants