Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Experiment creator state flags #7

Merged
merged 6 commits into from
Nov 6, 2024

Conversation

arik-shurygin
Copy link
Collaborator

the create_experiment script will now delete the states/ directory of the experiment by default, meaning that multiple calls to create_experiment will not append more states in the states/ directory, all files will be removed and then your new selection will be placed within.

The reason this change was made was due to bugs that would arise when a user made multiple calls to create_experiment with different states passed through the -s flag where stale states were not being removed and would be launched along with the intended states.

Furthermore this PR adds two new flag options with the -s:
all still creates a directory for every state/region/territory (including all HHS regions, Puerto Rico, and DC)
hhsregions creates 10 directories, one per region
50states creates one directory per state (excluding DC/PR/US).

Also pushed some code used to generate a single combination CSV so the create_experiment script does not need to load/parse separate files anymore.
CLOSES #3

Copy link
Collaborator

@kokbent kokbent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's go!

@arik-shurygin arik-shurygin merged commit f46266d into main Nov 6, 2024
2 checks passed
@arik-shurygin arik-shurygin deleted the experiment-creator-state-flags branch November 6, 2024 19:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Choices of -s all in experiment creator
2 participants