Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement updates to the API Programmer's Guide online content + PDF #16450

Conversation

jpandersen87
Copy link
Collaborator

Fixes #16289

This PR makes the requested content changes, in addition to:

  • Moves all usages of smartsheet, one pager pdf, and nist validator tool urls to site.json
  • Removes references to "Sample payloads and output" page from app router and sitemap (code kept as it may return)
    • E2E test is skipped

@jpandersen87 jpandersen87 self-assigned this Nov 5, 2024
Copy link

github-actions bot commented Nov 5, 2024

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

OpenSSF Scorecard

PackageVersionScoreDetails

Scanned Manifest Files

@jpandersen87 jpandersen87 added trialfrontend01 Trigger a trialfrontend01 deployment frontend Work Type label to flag work related to the front-end websites labels Nov 5, 2024
@jpandersen87 jpandersen87 added the design Work Type label to flag work related to UI/UX Design (e.g. service maps, wireframes, prototypes, etc label Nov 5, 2024
@jpandersen87
Copy link
Collaborator Author

@jillian-hammer should be ready for review on trialfrontend01 once it deploys

Copy link
Collaborator

@jillian-hammer jillian-hammer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @jpandersen87 - these changes look great. I caught one missing link. once that is changed, it's good to merge from a design pov!

Copy link
Collaborator

@jillian-hammer jillian-hammer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for adding the missing link - LGTM @jpandersen87

Copy link
Collaborator

@victor-chaparro victor-chaparro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

github-actions bot commented Nov 5, 2024

Branch deployed to Chromatic 🚀.

  • ⚠️ Detected 0 tests with visual changes.
  • ✅ All tests passed.

View via:

Copy link

sonarcloud bot commented Nov 5, 2024

@jpandersen87 jpandersen87 merged commit 908d24e into master Nov 5, 2024
29 of 31 checks passed
@jpandersen87 jpandersen87 deleted the experience/16289-Implement-updates-to-the-API-Programmers-Guide-online-content-+-PDF branch November 5, 2024 17:37
Copy link

github-actions bot commented Nov 5, 2024

⚠️ Broken Links ⚠️

https://www.cdc.gov/od/foia

Error: Request failed with status code 403


https://www.hhs.gov/vulnerability-disclosure-policy/index.html

Error: Request failed with status code 403


https://www.hl7.org/implement/standards/product_brief.cfm?product_id=185

Error: Request failed with status code 403


https://www.cdc.gov/poxvirus/mpox/lab-personnel/report-results.html

Error: Request failed with status code 404


Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
design Work Type label to flag work related to UI/UX Design (e.g. service maps, wireframes, prototypes, etc frontend Work Type label to flag work related to the front-end websites trialfrontend01 Trigger a trialfrontend01 deployment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement updates to the API Programmer's Guide online content + PDF
4 participants