Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update for DCipher #16442

Merged
merged 7 commits into from
Nov 5, 2024
Merged

update for DCipher #16442

merged 7 commits into from
Nov 5, 2024

Conversation

kobiehorne
Copy link
Collaborator

This PR: Update for DCipher ticket - 16388
Made modifications for Dcipher and fixed de-identifying for OBX-24

If you are suggesting a fix for a currently exploitable issue, please disclose the issue to the prime-reportstream team directly outside of GitHub instead of filing a PR, so we may immediately patch the affected systems before a disclosure. See SECURITY.md/Reporting a Vulnerability for more information.

Test Steps:

  1. Load new receiver: hhs-protect.yml
  2. Send HL7 Message as ignore.ignore-mars-otc
  3. Verify message gets routed to hhs-protect and confirm file was identified as found in document- https://www.nibib.nih.gov/covid-19/radx-tech-program/mars/hl7-message-de-identification-for-sending-to-hhs-protect

Changes

  • Added his-protect.yml
  • Updated de-identification rules

Checklist

Testing

  • Tested locally?
  • Ran ./prime test or ./gradlew testSmoke against local Docker ReportStream container?
  • (For Changes to /frontend-react/...) Ran npm run lint:write?
  • Added tests?

@kobiehorne kobiehorne requested a review from a team as a code owner November 4, 2024 20:39
Copy link

github-actions bot commented Nov 4, 2024

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

OpenSSF Scorecard

PackageVersionScoreDetails

Scanned Manifest Files

Copy link
Collaborator

@victor-chaparro victor-chaparro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

github-actions bot commented Nov 4, 2024

Test Results

1 247 tests  ±0   1 243 ✅ ±0   7m 30s ⏱️ -20s
  162 suites ±0       4 💤 ±0 
  162 files   ±0       0 ❌ ±0 

Results for commit d3d8156. ± Comparison against base commit 908d24e.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Nov 4, 2024

Integration Test Results

 53 files   53 suites   27m 41s ⏱️
411 tests 402 ✅ 9 💤 0 ❌
414 runs  405 ✅ 9 💤 0 ❌

Results for commit d3d8156.

♻️ This comment has been updated with latest results.

Copy link

sonarcloud bot commented Nov 5, 2024

@kobiehorne kobiehorne merged commit 9500375 into master Nov 5, 2024
23 checks passed
@kobiehorne kobiehorne deleted the dcipher-update-11-1-24 branch November 5, 2024 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants