Adding test member oid as the extension to all observations in the el… #16397

kant777 · 2024-10-30T03:04:48Z

…r messages

This PR adds the member OID as the extension to all observations in the elr messages.

Test Steps:

Include steps to test these changes

Changes

The ConditionStamper will now handle both condition lookups and Member OID stamping based on the logic and constants from ObservationMappingConstants

Checklist

Testing

Tested locally? yes
Ran ./prime test or ./gradlew testSmoke against local Docker ReportStream container? yes
Added tests? yes

Linked Issues

Fixes Map CSTE Member OID to member-oid extension during convert-step #14511

github-actions · 2024-10-30T03:05:04Z

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

OpenSSF Scorecard

Package	Version	Score	Details

Scanned Manifest Files

github-actions · 2024-10-30T03:18:47Z

Test Results

1 249 tests +2 1 243 ✅ ±0 7m 5s ⏱️ -45s
162 suites ±0 4 💤 ±0
162 files ±0 2 ❌ +2

For more details on these failures, see this check.

Results for commit 5536e4a. ± Comparison against base commit abfc0c0.

♻️ This comment has been updated with latest results.

github-actions · 2024-10-30T03:39:14Z

Integration Test Results

0 tests 0 ✅ 0s ⏱️
0 suites 0 💤
0 files 0 ❌

Results for commit 5536e4a.

♻️ This comment has been updated with latest results.

sonarcloud · 2024-11-07T13:37:06Z

Quality Gate failed

Failed conditions
62.5% Coverage on New Code (required ≥ 80%)

See analysis details on SonarCloud

david-navapbc

I don't see where AC "The process to determine results are antigen is documented" is met.

I also don't see any new tests.

Please address the above and I'll take another look.

ty!

david-navapbc · 2024-11-07T17:49:38Z

prime-router/src/main/kotlin/azure/ConditionMapper.kt

@@ -34,16 +42,32 @@ class LookupTableConditionMapper(metadata: Metadata) : IConditionMapper {
                acc
            }
    }
+
+    override fun lookupMemberOid(codings: List<Coding>): Map<String, String> {
+        return mappingTable.FilterBuilder()


this statement is dense and difficult to parse. In future please don't pack so much logic into the return statement

prime-router/src/main/kotlin/azure/ConditionMapper.kt

arnejduranovic

Changes look good, but I agree with the need for tests. At a minimum, an integration test similar to: should send valid FHIR report filtered by mapped condition filter. This would also show what a FHIRExpression filter would look like. Also see FHIRBundleHelpersTest (like addMappedCondition supports adding a condition when code is null) for guidance on unit tests.

prime-router/src/main/kotlin/azure/ConditionMapper.kt

arnejduranovic · 2024-11-12T17:00:23Z

prime-router/src/main/kotlin/azure/ConditionMapper.kt

+                }
+                acc
+            }
+    }
 }

 class ConditionStamper(private val conditionMapper: IConditionMapper) {
    companion object {
        const val conditionCodeExtensionURL = "https://reportstream.cdc.gov/fhir/StructureDefinition/condition-code"


We can fix the IntelliJ warning on this var name while we're here?

yes please. Trying to see how to fix this?

kant777 · 2024-11-12T19:54:34Z

I don't see where AC "The process to determine results are antigen is documented" is met.

I also don't see any new tests.

Please address the above and I'll take another look.

ty!

Sorry the tests were in another branch. rebased and merged.

…r messages

kant777 requested a review from a team as a code owner October 30, 2024 03:04

kant777 temporarily deployed to staging October 30, 2024 03:05 — with GitHub Actions Inactive

kant777 changed the title ~~Adding test member oid as the extension to all observations in the el…~~ [DRAFT] Adding test member oid as the extension to all observations in the el… Oct 30, 2024

kant777 mentioned this pull request Nov 7, 2024

Map CSTE Member OID to member-oid extension during convert-step #14511

Open

3 tasks

kant777 force-pushed the feature/14511-add-test-member-oid-extension branch from c4d718e to 884f3fe Compare November 7, 2024 13:14

kant777 temporarily deployed to staging November 7, 2024 13:14 — with GitHub Actions Inactive

kant777 changed the title ~~[DRAFT] Adding test member oid as the extension to all observations in the el…~~ Adding test member oid as the extension to all observations in the el… Nov 7, 2024

kant777 added the platform Platform Team label Nov 7, 2024

MichaelEsuruoso assigned david-navapbc Nov 7, 2024

david-navapbc requested changes Nov 7, 2024

View reviewed changes

arnejduranovic reviewed Nov 12, 2024

View reviewed changes

kant777 force-pushed the feature/14511-add-test-member-oid-extension branch from 884f3fe to 9943de0 Compare November 12, 2024 19:32

kant777 temporarily deployed to staging November 12, 2024 19:33 — with GitHub Actions Inactive

kant777 force-pushed the feature/14511-add-test-member-oid-extension branch from 9943de0 to 04bd870 Compare November 12, 2024 19:33

kant777 temporarily deployed to staging November 12, 2024 19:33 — with GitHub Actions Inactive

kant777 force-pushed the feature/14511-add-test-member-oid-extension branch from 04bd870 to ead1fd8 Compare November 12, 2024 19:52

kant777 temporarily deployed to staging November 12, 2024 19:52 — with GitHub Actions Inactive

kant777 force-pushed the feature/14511-add-test-member-oid-extension branch from ead1fd8 to cb7de06 Compare November 12, 2024 19:53

kant777 temporarily deployed to staging November 12, 2024 19:54 — with GitHub Actions Inactive

Adding test member oid as the extension to all observations in the el…

5536e4a

…r messages

kant777 force-pushed the feature/14511-add-test-member-oid-extension branch from cb7de06 to 5536e4a Compare November 12, 2024 21:21

kant777 temporarily deployed to staging November 12, 2024 21:22 — with GitHub Actions Inactive

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Adding test member oid as the extension to all observations in the el… #16397

Adding test member oid as the extension to all observations in the el… #16397

kant777 commented Oct 30, 2024 •

edited

Loading

github-actions bot commented Oct 30, 2024 •

edited

Loading

github-actions bot commented Oct 30, 2024 •

edited

Loading

github-actions bot commented Oct 30, 2024 •

edited

Loading

sonarcloud bot commented Nov 7, 2024

david-navapbc left a comment

david-navapbc Nov 7, 2024

arnejduranovic left a comment •

edited

Loading

arnejduranovic Nov 12, 2024

kant777 Nov 12, 2024

kant777 commented Nov 12, 2024

Adding test member oid as the extension to all observations in the el… #16397

Are you sure you want to change the base?

Adding test member oid as the extension to all observations in the el… #16397

Conversation

kant777 commented Oct 30, 2024 • edited Loading

Changes

Checklist

Testing

Linked Issues

github-actions bot commented Oct 30, 2024 • edited Loading

Dependency Review

OpenSSF Scorecard

Scanned Manifest Files

github-actions bot commented Oct 30, 2024 • edited Loading

Test Results

github-actions bot commented Oct 30, 2024 • edited Loading

Integration Test Results

sonarcloud bot commented Nov 7, 2024

Quality Gate failed

david-navapbc left a comment

Choose a reason for hiding this comment

david-navapbc Nov 7, 2024

Choose a reason for hiding this comment

arnejduranovic left a comment • edited Loading

Choose a reason for hiding this comment

arnejduranovic Nov 12, 2024

Choose a reason for hiding this comment

kant777 Nov 12, 2024

Choose a reason for hiding this comment

kant777 commented Nov 12, 2024

kant777 commented Oct 30, 2024 •

edited

Loading

github-actions bot commented Oct 30, 2024 •

edited

Loading

github-actions bot commented Oct 30, 2024 •

edited

Loading

github-actions bot commented Oct 30, 2024 •

edited

Loading

arnejduranovic left a comment •

edited

Loading