Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Demonstration Primarily For NNH At PyRenew Meeting #40

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

AFg6K7h4fhy2
Copy link
Collaborator

The scope of this PR can be found in Issue #31 .

@AFg6K7h4fhy2 AFg6K7h4fhy2 linked an issue Nov 18, 2024 that may be closed by this pull request
@AFg6K7h4fhy2 AFg6K7h4fhy2 self-assigned this Nov 18, 2024
@AFg6K7h4fhy2 AFg6K7h4fhy2 added user-feedback Pertaining to user feedback for certain items in the code-base. High Priority labels Nov 18, 2024
@AFg6K7h4fhy2
Copy link
Collaborator Author

The demonstration lives temporarily in #35, since PR 35 has major un-merged changes that are important for the demonstration. Right before PR 35 gets merged to main, the demonstration will be moved back to this PR. Then, the changes from PR 35 will be pulled from main into this PR and this PR will get merged to main (with the demo. notebook).

@AFg6K7h4fhy2
Copy link
Collaborator Author

What was shown during the demonstration was an HTML file produced by running

quarto render forecasttools_community_demo_2024-11-19.qmd

The HTML file was clicked on an displayed in the most recent version of the FireFox browser.

@AFg6K7h4fhy2 AFg6K7h4fhy2 marked this pull request as ready for review November 19, 2024 17:45
@AFg6K7h4fhy2
Copy link
Collaborator Author

AFg6K7h4fhy2 commented Nov 19, 2024

An open question is whether this notebook should exist in its current form in this repository. The author's belief is that it should, conditionally possibly on the presence of two contextual statements, one in the README (describing the notebooks) and another in forecasttools_community_demo_2024-11-19.qmd describing the context for the presentation.

@dylanhmorris

@dylanhmorris
Copy link
Collaborator

I think it should be in the repo, eventually as part of the formal documentation. For now it can live in a notebooks directory, since I think documentation is a much larger lift.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
High Priority user-feedback Pertaining to user feedback for certain items in the code-base.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Demonstration Primarily For NNH At PyRenew Meeting
2 participants