Example run changes directory to repository root #289
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arik-shurygin
requested changes
Oct 24, 2024
|
|
||
| os.chdir(ROOT_PATH) | ||
|
|
||
| # the different segments of code responsible for running the model |
There was a problem hiding this comment.
This causes the file to fail pre-commit checks: E402 Module level import not at top of file. You have two solutions, either add the following command: # ruff: noqa: E402 to disable the particular pre-commit check. Or move the lines below the import. I suggest the latter unless you have a good reason to keep the current ordering
|
I'll take a look at this on Tuesday. |
|
I think it probably makes sense to punt this kind of thing until after the packages get reorg'd and relative paths get re-thought. At that point we can identify the best non-hacky solution—I suspect there's a "correct" way to do this that doesn't involve messing with the python search path at runtime. @arik-shurygin agree? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The example depends on being run in the root directory of the repo.
This minimal change simply does a
cdinto the root directory of the repo. A longer-term conversation: how do paths work relative to scripts, config files, etc., etc.? Best not to change anything significant until the reproducibility model stabilizes.Also modified path computations to use
os.path.join().