locking cfa_azure version, adding state suffix to task ids #286
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kokbent
reviewed
Oct 23, 2024
| @@ -22,7 +22,7 @@ pandas = ">=2.0.3" | |||
| seaborn = ">=0.13.2" | |||
| shiny = ">=0.6.0" | |||
| pytest = ">=7.4.0" | |||
| cfa-azure = {git = "https://github.com/CDCgov/cfa_azure.git"} | |||
| cfa-azure = {git = "https://github.com/CDCgov/cfa_azure.git", rev="5443bde"} | |||
There was a problem hiding this comment.
would have prefer using tag="v1.0.6" or something but not fuss about it lol
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
upgrading and locking cfa_azure version to commit hash: 5443bde or version 1.0.8. This upgrade adds the ability for us to specify suffix onto each task launched. I went ahead and added the state name as the default suffix to aid in interpretability when reading task lists in batch explorer.
This upgrade also changes some keys in the configuration toml, please reach out to me if you are getting weird errors when trying to launch your jobs and I can pass you the file in a safe way (it is not tracked on git for obvious reasons)