Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removing stale utils functions #249

Merged
merged 3 commits into from
Sep 26, 2024
Merged

Removing stale utils functions #249

merged 3 commits into from
Sep 26, 2024

Conversation

arik-shurygin
Copy link
Collaborator

removing all functions from the following deprecated use cases:

  • ABM initializer utils functions
  • OLD sero initializer utils functions
  • deprecated utils functions for converting model to json representation

@arik-shurygin
Copy link
Collaborator Author

this fails pytest for now because we need to merge #243 first

kokbent
kokbent approved these changes Sep 26, 2024
View reviewed changes
Copy link
Collaborator

@kokbent kokbent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lego

@arik-shurygin arik-shurygin merged commit 408dd65 into main Sep 26, 2024
2 checks passed
@arik-shurygin arik-shurygin deleted the removing-init-utils-functions branch September 26, 2024 17:08
@tjhladish
Copy link
Collaborator

Let's get together Monday

@arik-shurygin arik-shurygin mentioned this pull request Sep 26, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kokbent kokbent kokbent approved these changes

@tjhladish tjhladish Awaiting requested review from tjhladish

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@arik-shurygin @tjhladish @kokbent