Add file encoding detection #100
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix issue when component is unmounted immediately after file load in CSVReader
Fix unmount issue with CSVReader
v4.0.0 Bunlong#98
|
Any updates on this? We would need this feature for our application. The merge would be highly appreciated! |
|
@kstrub PR will be merged in next version |
|
@exaucae Could you please resolve the conflicts? |
|
Sure, I'll ping you when done, @Bunlong, tonight. |
|
If you test it and are okay with changes, we can move on, @Bunlong . |
|
Why is this awesome PR not merged? |
|
any update on this ?? |
|
Is this PR expected to be merged? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Inspired by this blogpost idea .
The encoding should now be inferred if not specified in the config properties.
Closes #82