Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix fromInfinite error #41

Merged
merged 2 commits into from
Apr 12, 2024
Merged

Fix fromInfinite error #41

merged 2 commits into from
Apr 12, 2024

Commits on Apr 12, 2024

  1. Add test for fromInfinite

    @pgujjula
    pgujjula committed Apr 12, 2024
    Configuration menu
    Copy the full SHA
    a1ab71a View commit details
    Browse the repository at this point in the history

  2. #40 Fix fromInfinite error 

    In the implementation of fromInfinite, we pass an infinite list to
Data.Primitive.Array.fromListN (bits + 1), but fromListN expects a list
a list of length (bits + 1), which results in a runtime error.

To fix this, we add a check in go to break recursion and to ensure that
the list that is passed into fromListN has length (bits + 1).
    @pgujjula
    pgujjula committed Apr 12, 2024
    Configuration menu
    Copy the full SHA
    cf0108c View commit details
    Browse the repository at this point in the history