Fix fromInfinite error
#41
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Apr 12, 2024
Closed
Bodigrim
reviewed
Apr 12, 2024
src/Data/Chimera/Internal.hs
Outdated
| @@ -568,7 +568,7 @@ fromInfinite | |||
| :: G.Vector v a | |||
| => Infinite a | |||
| -> Chimera v a | |||
| fromInfinite = Chimera . fromListN (bits + 1) . go0 | |||
| fromInfinite = Chimera . fromListN (bits + 1) . take (bits + 1) . go0 | |||
There was a problem hiding this comment.
Could we not produce more than bits + 1 elements in the first place? I imagine a check in go to break recursion could help.
There was a problem hiding this comment.
That's true, I've updated the PR accordingly.
In the implementation of fromInfinite, we pass an infinite list to Data.Primitive.Array.fromListN (bits + 1), but fromListN expects a list a list of length (bits + 1), which results in a runtime error. To fix this, we add a check in go to break recursion and to ensure that the list that is passed into fromListN has length (bits + 1).
Bodigrim
approved these changes
Apr 12, 2024
Closed
|
Thanks a lot! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the implementation of
fromInfinite, we pass an infinite list toData.Primitive.Array.fromListN (bits + 1), butfromListNexpects a list a list of lengthbits + 1, which results in a runtime error.To fix this, we take the firstbits + 1of the infinite list before passing tofromListN.Updated solution: To fix this, we add a check in
goto break recursion and to ensure that the list that is passed intofromListNhas lengthbits + 1.Fixes issue #40