Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes Offset Table #11872

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
+16 −23
Open

Fixes Offset Table #11872

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
44cc77b
Update MetaStation.dmm
MarkusLarsson421 Nov 11, 2024
ebfca23
adds table pixel shift lint
MarkusLarsson421 Nov 11, 2024
9a7e4a1
Update table_pixel_shifts.yml
MarkusLarsson421 Nov 11, 2024
b4d8388
pixel shift the table again for testing
MarkusLarsson421 Nov 11, 2024
2d4c467
lint errors
MarkusLarsson421 Nov 11, 2024
8d5ef3c
surgery drapes can't be at X0 Y0?
MarkusLarsson421 Nov 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 3 additions & 5 deletions _maps/map_files/EchoStation/EchoStation.dmm
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 1 addition & 3 deletions _maps/map_files/MetaStation/MetaStation.dmm
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

17 changes: 6 additions & 11 deletions _maps/map_files/RadStation/RadStation.dmm
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 2 additions & 4 deletions _maps/templates/shelter_2.dmm
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 4 additions & 0 deletions tools/maplint/lints/table_pixel_shifts.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
/obj/structure/table:
banned_variables:
pixel_x:
pixel_y:
Comment on lines +3 to +4
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
pixel_x:
pixel_y:
- pixel_x
- pixel_y

This is only syntactic, but name: should be used for when we are defining something inside of it:

If we want to be more specific, we can write out the specific variables we want to ban.

/mob/dog
  banned_variables:
  - species # Don't var-edit species, use the subtypes

We can also explicitly create allowlists and denylists of values through allow and deny. For example, if we want to make sure we're not creating invalid bowls for animals, we can write:

/obj/bowl/dog:
  banned_variables:
    species:
      # If we specify a species, it's gotta be a dog
      allow: ["beagle", "corgi", "pomeranian"]

/obj/bowl/humans:
  banned_variables:
    species:
      # We're civilized, we don't want to eat from the same bowl that's var-edited for animals
      deny: ["cats", "dogs"]

Loading