Fixes Offset Table #11872
Open
Fixes Offset Table #11872
+16
−23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The smallest PR I've made to date. |
|
soul removal 🔑 |
Comment on lines
+3
to
+4
| pixel_x: | ||
| pixel_y: |
There was a problem hiding this comment.
Suggested change
| pixel_x: | |
| pixel_y: | |
| - pixel_x | |
| - pixel_y |
This is only syntactic, but name: should be used for when we are defining something inside of it:
If we want to be more specific, we can write out the specific variables we want to ban.
/mob/dog
banned_variables:
- species # Don't var-edit species, use the subtypesWe can also explicitly create allowlists and denylists of values through allow and deny. For example, if we want to make sure we're not creating invalid bowls for animals, we can write:
/obj/bowl/dog:
banned_variables:
species:
# If we specify a species, it's gotta be a dog
allow: ["beagle", "corgi", "pomeranian"]
/obj/bowl/humans:
banned_variables:
species:
# We're civilized, we don't want to eat from the same bowl that's var-edited for animals
deny: ["cats", "dogs"]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About The Pull Request
Table in Science Security has been offset for like two months now. Time to fix it.
Why It's Good For The Game
Maybe finally BeeStation with get 100+ pop?
Testing Photographs and Procedure
Screenshots&Videos
Works!
Changelog
🆑
fix: (Meta) Fixed offset table in Science Security Outpost.
/:cl: