Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Internal] Binary Encoding: Fixes Performance Regression #4901

Merged
merged 5 commits into from
Nov 25, 2024
Merged

[Internal] Binary Encoding: Fixes Performance Regression #4901

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
d6e541b
Code changes to skip cloneable stream for non binary flow.
kundadebdatta Nov 21, 2024
251f69b
Merge branch 'master' into users/dkunda/4644_binary_encoding_test_fix…
kundadebdatta Nov 22, 2024
0b7ca57
Code changes to add explicit param names in Cloneable Stream.
kundadebdatta Nov 22, 2024
b08a906
Merge branch 'master' into users/dkunda/4644_binary_encoding_test_fix…
kundadebdatta Nov 23, 2024
865ec82
Merge branch 'master' into users/dkunda/4644_binary_encoding_test_fix…
kundadebdatta Nov 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion Microsoft.Azure.Cosmos/src/Handler/RequestInvokerHandler.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,7 +106,9 @@ public override async Task<ResponseMessage> SendAsync(
&& response.Content != null
&& response.Content is not CloneableStream)
{
response.Content = await StreamExtension.AsClonableStreamAsync(response.Content, default);
response.Content = await StreamExtension.AsClonableStreamAsync(
mediaStream: response.Content,
allowUnsafeDataAccess: true);
}

return response;
Expand Down
11 changes: 8 additions & 3 deletions Microsoft.Azure.Cosmos/src/Resource/Container/ContainerCore.Items.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -924,9 +924,14 @@ private async Task<ResponseMessage> ProcessItemStreamAsync(
string resourceUri = this.GetResourceUri(requestOptions, operationType, itemId);

// Convert Text to Binary Stream.
streamPayload = CosmosSerializationUtil.TrySerializeStreamToTargetFormat(
targetSerializationFormat: ContainerCore.GetTargetRequestSerializationFormat(),
inputStream: streamPayload == null ? null : await StreamExtension.AsClonableStreamAsync(streamPayload));
if (ConfigurationManager.IsBinaryEncodingEnabled())
kirankumarkolli marked this conversation as resolved.
Show resolved Hide resolved
{
streamPayload = CosmosSerializationUtil.TrySerializeStreamToTargetFormat(
targetSerializationFormat: ContainerCore.GetTargetRequestSerializationFormat(),
inputStream: streamPayload == null ? null : await StreamExtension.AsClonableStreamAsync(
mediaStream: streamPayload,
allowUnsafeDataAccess: true));
}

ResponseMessage responseMessage = await this.ClientContext.ProcessResourceOperationStreamAsync(
resourceUri: resourceUri,
Expand Down