[Internal] Binary Encoding: Fixes Performance Regression #4901
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
kundadebdatta
requested review from
kirankumarkolli,
FabianMeiswinkel,
sboshra and
Pilchie
as code owners
Pilchie
reviewed
Nov 22, 2024
kirankumarkolli
approved these changes
Nov 23, 2024
aavasthy
approved these changes
Nov 25, 2024
kirankumarkolli
deleted the
users/dkunda/4644_binary_encoding_test_fix_perf_regression
branch
kundadebdatta
added a commit
that referenced
this pull request
Jan 8, 2025
# Pull Request Template ## Description Recently during our v3 sdk CI rolling runs, we observed some performance regressions on the `ItemStreamAsync()` APIs. They regressed beyond 5%.  Upon doing further investigation, we figured out that during the non-binary flow, we end up converting the incoming stream into `CloneableStream` which might be the reason for this regression. Please note that the reason this was not caught during the [original version of the binary encoding PR](#4652) was that the performance test used to capture the benchmark for the original PR, was targeted a real cosmos container, where for the CI runs, we use our mocked containers. This PR skips `CloneableStream` conversation for non-binary encoding flow. With the above change in place, our CI builds started passing:  ## Type of change Please delete options that are not relevant. - [x] Bug fix (non-breaking change which fixes an issue) ## Closing issues To automatically close an issue: closes #IssueNumber
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Template
Description
Recently during our v3 sdk CI rolling runs, we observed some performance regressions on the
ItemStreamAsync()APIs. They regressed beyond 5%.Upon doing further investigation, we figured out that during the non-binary flow, we end up converting the incoming stream into
CloneableStreamwhich might be the reason for this regression. Please note that the reason this was not caught during the original version of the binary encoding PR was that the performance test used to capture the benchmark for the original PR, was targeted a real cosmos container, where for the CI runs, we use our mocked containers.This PR skips
CloneableStreamconversation for non-binary encoding flow.With the above change in place, our CI builds started passing:
Type of change
Please delete options that are not relevant.
Closing issues
To automatically close an issue: closes #IssueNumber