Subscribers store: convert generators to thunks

[jsnajdr]

Converts the Subscribers store actions from generators to thunks. That's the modern and easier-to-understand way to do actions in data stores.

How to test:
Go to the /subscribers/:site page in Calypso and in Jetpack Cloud and verify that the subsciber import flows continue to work correctly.

[github-actions]

Calypso Live (direct link)

https://calypso.live?image=registry.a8c.com/calypso/app:build-129749

Jetpack Cloud live (direct link)

https://calypso.live?image=registry.a8c.com/calypso/app:build-129749&env=jetpack

Automattic for Agencies live (direct link)

https://calypso.live?image=registry.a8c.com/calypso/app:build-129749&env=a8c-for-agencies

[matticbot]

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

• notifications
• wpcom-block-editor

To test WordPress.com changes, run install-plugin.sh $pluginSlug thunkify/subscribers on your sandbox.

[matticbot]

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Sections (~91 bytes removed 📉 [gzipped])

name         parsed_size           gzip_size
subscribers       +159 B  (+0.0%)      -17 B  (-0.0%)
people            +159 B  (+0.0%)      -37 B  (-0.0%)
import            +111 B  (+0.0%)      -37 B  (-0.0%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

[allilevine]

I tested:

• Manual import in both Calypso Blue and Green.
• CSV import in both Calypo Blue and Green.
• Manual and CSV imports with categories in Calypso Blue.
• Substack subscriber import.

[jsnajdr]

Thanks for the review @allilevine 👍 Do you happen to know if the Subcribers store is used anywhere outside Calypso? What about other stores in the data-stores packages? I have ideas for some potential changes and would like to know how breaking they can be.

[simison]

Subscribers store AFAIK is used just in Calypso blue & Jetpack Cloud; the only other place would be Jetpack plugins.

[allilevine]

Thanks for the review @allilevine 👍 Do you happen to know if the Subcribers store is used anywhere outside Calypso? What about other stores in the data-stores packages? I have ideas for some potential changes and would like to know how breaking they can be.

@jsnajdr I'm not aware of any Subscriber store uses outside Calypso, as Mikael commented. It looks like it was intended to be consumed outside of Calypso, but I haven't seen any evidence that it was: pcmemI-Jw-p2#comment-901

I worked on packages/data-stores/src/newsletter-categories/index.ts recently and that's also used in Calypso. The README says "It is meant to be helpful for projects developed inside the Calypso monorepo."

[tyxla]

LGTM, thanks for the cleanup @jsnajdr!