-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Launchpad Navigator: Remove from Calypso #98401
base: trunk
Are you sure you want to change the base?
Conversation
Jetpack Cloud live (direct link)
Automattic for Agencies live (direct link)
|
Here is how your PR affects size of JS and CSS bundles shipped to the user's browser: App Entrypoints (~154 bytes removed 📉 [gzipped])
Common code that is always downloaded and parsed every time the app is loaded, no matter which route is used. Sections (~11641 bytes removed 📉 [gzipped])
Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to. Async-loaded Components (~10374 bytes removed 📉 [gzipped])
React components that are loaded lazily, when a certain part of UI is displayed for the first time. Legend What is parsed and gzip size?Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory. Generated by performance advisor bot at iscalypsofastyet.com. |
Proposed Changes
Remove the disabled Launchpad Navigator from Calypso.
Why are these changes being made?
It's been over a year since the Launchpad Navigator meetup project was shelved.
It was still then considered that it's uncertain it actually solves a real user problem, and I don't see any updates on this. Should we want to bring it back, it's quite straightforward to revert this PR.
With that in mind, we should be able to remove it altogether.
See paYKcK-3CA-p2 for context.
I spotted this while reviewing #98333 (cc @jsnajdr) and found it's a good opportunity for cleaning up dead code, rather than refactoring the
LaunchpadNavigator
data store away from generators.Testing Instructions