Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Launchpad Navigator: Remove from Calypso #98401

Open
wants to merge 1 commit into
base: trunk
Choose a base branch
from

Conversation

tyxla
Copy link
Member

@tyxla tyxla commented Jan 15, 2025

Proposed Changes

Remove the disabled Launchpad Navigator from Calypso.

Why are these changes being made?

It's been over a year since the Launchpad Navigator meetup project was shelved.
It was still then considered that it's uncertain it actually solves a real user problem, and I don't see any updates on this. Should we want to bring it back, it's quite straightforward to revert this PR.
With that in mind, we should be able to remove it altogether.

See paYKcK-3CA-p2 for context.

I spotted this while reviewing #98333 (cc @jsnajdr) and found it's a good opportunity for cleaning up dead code, rather than refactoring the LaunchpadNavigator data store away from generators.

Testing Instructions

  • Verify Calypso builds well and all checks are green.
  • Smoke test the Launchpad and verify it works well.
  • Verify in one of the steps that disable the launchpad that it still disables it correctly.

@tyxla tyxla added [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. [Type] Janitorial [Feature] Launchpad The onboarding Launchpad that guides users through setting up their site and getting it launched. [Feature Group] Launchpad labels Jan 15, 2025
@tyxla tyxla requested a review from a team January 15, 2025 08:09
@tyxla tyxla self-assigned this Jan 15, 2025
@tyxla tyxla requested a review from a team as a code owner January 15, 2025 08:09
@matticbot
Copy link
Contributor

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

App Entrypoints (~154 bytes removed 📉 [gzipped])

name                   parsed_size           gzip_size
entry-login                 -877 B  (-0.0%)     -155 B  (-0.0%)
entry-main                  -553 B  (-0.0%)     -107 B  (-0.0%)
entry-subscriptions          -97 B  (-0.0%)      -73 B  (-0.0%)
entry-domains-landing        -97 B  (-0.0%)      -73 B  (-0.0%)
entry-browsehappy            -97 B  (-0.0%)      -73 B  (-0.1%)
entry-stepper                -30 B  (-0.0%)     -120 B  (-0.0%)

Common code that is always downloaded and parsed every time the app is loaded, no matter which route is used.

Sections (~11641 bytes removed 📉 [gzipped])

name                           parsed_size           gzip_size
link-in-bio-tld-flow               -2677 B  (-0.1%)      -91 B  (-0.0%)
write-flow                         -2541 B  (-0.2%)     -638 B  (-0.2%)
build-flow                         -2541 B  (-0.2%)     -648 B  (-0.2%)
design-first-flow                  -2432 B  (-6.1%)     -601 B  (-6.5%)
readymade-template-flow            -2427 B  (-1.2%)     -568 B  (-0.9%)
assembler-first-flow               -2427 B  (-1.4%)     -588 B  (-1.1%)
start-writing-flow                 -2424 B  (-6.2%)     -600 B  (-6.5%)
newsletter-flow                    -2421 B  (-7.1%)     -592 B  (-6.7%)
transferring-hosted-site-flow      -2270 B  (-0.8%)    -1218 B  (-1.3%)
home                               -2177 B  (-0.1%)     -500 B  (-0.1%)
earn                               -2177 B  (-0.3%)     -480 B  (-0.2%)
subscribers                        -1981 B  (-0.1%)     +688 B  (+0.2%)
media                               -269 B  (-0.0%)     +394 B  (+0.1%)
devdocs                             +228 B  (+0.1%)      +31 B  (+0.1%)
plugins                             +183 B  (+0.0%)     +679 B  (+0.1%)
stats                               +128 B  (+0.0%)      +28 B  (+0.0%)
update-design-flow                  -103 B  (-0.0%)      +15 B  (+0.0%)
settings                            -103 B  (-0.0%)      -12 B  (-0.0%)
promote-post-i2                     -103 B  (-0.0%)      -14 B  (-0.0%)
newsletter-post-setup-flow          -103 B  (-0.0%)      -10 B  (-0.0%)
link-in-bio-post-setup-flow         -103 B  (-0.0%)      -10 B  (-0.0%)
backup                              -103 B  (-0.0%)      -13 B  (-0.0%)
import-hosted-site-flow              -37 B  (-0.0%)      +44 B  (+0.0%)
plans                                +13 B  (+0.0%)      +26 B  (+0.0%)
jetpack-app                          +13 B  (+0.0%)      +21 B  (+0.0%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Async-loaded Components (~10374 bytes removed 📉 [gzipped])

name                                                 parsed_size             gzip_size
async-load-masterbar-launchpad-navigator                -82203 B  (deleted)   -26212 B  (deleted)
async-load-calypso-my-sites-stats-pages-subscribers      -2074 B    (-1.4%)     -218 B    (-0.4%)
async-load-calypso-lib-account-settings-helper            +208 B    (+0.1%)      +23 B    (+0.0%)
async-load-design-playground                              +195 B    (+0.0%)     +138 B    (+0.0%)
async-load-design                                         +195 B    (+0.0%)     +138 B    (+0.0%)
async-load-design-blocks                                  +183 B    (+0.0%)     +976 B    (+0.2%)
async-load-calypso-post-editor-media-modal                +143 B    (+0.0%)     +372 B    (+0.1%)
async-load-calypso-post-editor-editor-media-modal         +143 B    (+0.0%)     +367 B    (+0.1%)
async-load-signup-steps-plans-theme-preselected            +13 B    (+0.0%)      +21 B    (+0.0%)
async-load-signup-steps-plans                              +13 B    (+0.0%)      +21 B    (+0.0%)

React components that are loaded lazily, when a certain part of UI is displayed for the first time.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature Group] Launchpad [Feature] Launchpad The onboarding Launchpad that guides users through setting up their site and getting it launched. [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. [Type] Janitorial
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants