-
Notifications
You must be signed in to change notification settings - Fork 207
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(fast-usdc): cli deposit command (WIP) #10441
Draft
dckc
wants to merge
28
commits into
master
Choose a base branch
from
dc-rpc-sim
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
+2,684
−102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- using contractSupport/ratio upgrades zoe from devDependencies
and elaborate deposit/withdraw test in story form
`fileURLToPath` suggests authority to resolve paths anywhere in the filesystem. `nodeRequire.resolve` is explicitly about resolving paths to parts of packages. `readFileSync` suggests authority to read any file. Aliasing to `loadTextModule` documents the intention to load text from source code in the package.
- ChainWatcher.queryOnce work-alike - marshal-tables - vstorage readStorage - cosmos API getJSON with injected fetch
lifted from in-progress PR: feat: inter-tool bid list #7939 https://github.com/Agoric/agoric-sdk/blob/6045ee17ce409400e48deb8e470f39b0a192b91e/packages/inter-cli/test/test-auction.js#L107-L132
samsiegart
force-pushed
the
srs-fu-cli
branch
from
November 11, 2024 18:45
cdc9d32
to
04f8e3f
Compare
samsiegart
force-pushed
the
srs-fu-cli
branch
4 times, most recently
from
November 14, 2024 04:28
98d08f3
to
d46cefd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
fetch
stacked on
I don't know what's up with the 147 commits. This PR is just an invitation to discuss these...
2024-11-09 22:27 9ffdc26 feat(cli): deposit (WIP)
2024-11-09 22:23 3c8f8e1 chore: encodeDetail testing utility
2024-11-10 01:54 b3102c5 chore: vstorage queryOnce etc. w/injected fetch (WIP)
2024-11-09 22:26 3b3bd99 chore(deps): casting for web recording testing tool
2024-11-09 22:29 e328419 chore: notes on injecting IO in cli/transfer.js (WIP)
2024-11-09 22:22 44c3283 docs: deprecate IO at module init time
2024-11-09 22:16 b72becd refactor: clarify that access to package.json is a link-time thing
2024-11-10 01:58 dea18ff test: static type for deposit proposal
2024-11-10 01:56 7146d95 fix(casting): captureIO was missing resp.ok
2024-11-08 10:48 00be8c1 Merge remote-tracking branch 'origin/srs-fu-cli' into dc-rpc-sim
Security Considerations
Scaling Considerations
Documentation Considerations
Testing Considerations
Upgrade Considerations