Fast USDC CLI: Transfer #10437

samsiegart · 2024-11-09T04:11:05Z

refs #10339

Description

Adds a config command for setting all the required variables relating to IBC channels, mnemonics, rpc endpoints, etc.
Adds a transfer command for simulating the Noble Express frontend. It accepts an end user cosmos address destination, and a USDC amount as args. TODO: It should query the agoric Fast USDC LCA address, but for now it just stubs a hardcoded address there, because I'm not sure what the query should look like.
Also TODO, add a command to query the status of pending transfers

Documentation Considerations

Tried to make the help command as self-documenting as possible

Testing Considerations

Manually tested on testnets with testnet tokens that:

It queries the noble forwarding address for the "agoricXXX?EUD=dydxYYY" address
It registers the forwarding address on noble if it doesn't exist yet (I tested on noble mainnet for this part actually, not testnet)
It sends a depositForBurn txn on ethereum (I used sepolia testnet) with the correctly encoded noble address: https://sepolia.etherscan.io/tx/0xde6d7ea6a6d2737e67524dca70372610c5ac0476d75d4c30fc4270e89e36de77

I put the config used for that test run in demo/testnet for reference.

Added unit tests for all the config stuff, but didn't unit test "transfer" yet. Maybe e2e tests would be better for that part...

Upgrade Considerations

The CLI is a client program and doesn't need to be upgraded in production.

cloudflare-workers-and-pages · 2024-11-09T04:13:24Z

Deploying agoric-sdk with Cloudflare Pages

Latest commit:	`d46cefd`
Status:	✅ Deploy successful!
Preview URL:	https://bfa92667.agoric-sdk.pages.dev
Branch Preview URL:	https://srs-fu-cli.agoric-sdk.pages.dev

View logs

dckc · 2024-11-12T04:02:32Z

didn't unit test "transfer" yet.

Is there some particular reason to land this without such a test?

samsiegart · 2024-11-12T09:36:34Z

Is there some particular reason to land this without such a test?

Are you blocked on #10441? It would be better to merge this sooner than later so that we could make that PR fit the structure of this one.

If it's not a blocker, I can add the tests if this looks good to you so far. I mostly wanted to make sure my approach was agreeable before doing all that extra work. For example, removing mock-fs was significant feedback, and I might've been inclined to use a monkey-patching approach on the rest of the stuff otherwise. I've gone ahead and removed mock-fs though, and used file objects instead as discussed, so PTAL @dckc

dckc

2 more suggestions similar to file objects instead of filenames.

packages/fast-usdc/src/util/cctp.js

packages/fast-usdc/src/util/agoric.js

dckc · 2024-11-12T16:12:17Z

Is there some particular reason to land this without such a test?

Are you blocked on #10441?

No; #10441 is just for discussion. It's a bunch of suggestions about an approach for testing and such.

If it's not a blocker, I can add the tests if this looks good to you so far.

Sure, a lot of it looks good.

packages/fast-usdc/src/util/noble.js

dckc · 2024-11-12T22:27:36Z

packages/fast-usdc/src/util/file.js

+export const makeFile = (
+  /** @type {string} */ path,
+  /** @type {readAsync} */ readFile,
+  /** @type {writeAsync} */ writeFile,
+  /** @type {mkdirSync} */ mkdir,
+  /** @type {existsSync} */ pathExists,
+) => {


suggestion: With more than 3 args, naming them tends to help. It works nicely with Pick<typeof fs, 'readFile' | 'writeFile' | ...> too.

The args have gotten long in quite a few places because of the need for dependency injection, so I'll look through this last thing before merging to see if I can clean it up some.

dckc · 2024-11-12T22:43:11Z

packages/fast-usdc/src/util/noble.js

+  const clientWithSigner = await SigningStargateClient.connectWithSigner(
+    nobleRpc,


nobleRpc should be an RPC client object rather than a string. Something like this should work, based on some endo playground experience:

Use makeTendermintRpcClient(url, fetch) from casting and the rest comes from cosmjs:

import { Tendermint34Client } from '@cosmjs/tendermint-rpc'; ... const cometClient = await Tendermint34Client.create(rpcClient); const clientWithSigner = await SigningStargateClient.createWithSigner( cometClient, ...

Why though? It adds more dependencies and lines of code, while the SigningStargateClient interface supports a string

It adds more dependencies

It adds lines in package.json maybe, but the dependencies are already there, indirectly.

SigningStargateClient interface supports a string

yes, but that string separates designation from authority. If we pass a string, SigningStargateClient is going to use ambient access to the network - fetch or the like. How would we test registerFwdAccount? Perhaps there are tools that use global mutable state to override fetch. That sort of spooky action-at-a-distance is difficult to manage at scale. And it means registerFwdAccount doesn't support patterns of reuse such as passing in an RPCClient with built-in rate-limiting.

dckc · 2024-11-12T22:52:29Z

packages/fast-usdc/src/cli/cli.js

+  const makeConfigFile = () =>
+    makeFile(getConfigPath(), readFile, writeFile, mkdir, exists);


most of the code doesn't seem to need write access.

Consider grabbing makeFileRW and makeFileRd from synthetic-chain. make a RW and then call .readOnly(); only pass the RW to the things that need it.

we can do that later. not critical.

samsiegart · 2024-11-12T23:04:59Z

Added test coverage for the full transfer flow now

dckc

It mostly looks great, but...

It looks like it gives a successful exit code (0) on failure, which makes it unsuitable as an integration testing tool. See silent failure comments.

Consider the suggestions entirely at your discretion; feel free to ignore entirely, decline, adopt, adapt, etc.

dckc · 2024-11-13T03:10:45Z

packages/fast-usdc/test/cli/transfer.test.ts

+  t.deepEqual(signerMock.getSigned(), [
+    nobleSignerAddress,
+    [
+      {
+        typeUrl: '/noble.forwarding.v1.MsgRegisterAccount',
+        value: {
+          channel: nobleToAgoricChannel,
+          recipient: `${agoricSettlementAccount}+${destination}`,
+          signer: nobleSignerAddress,
+        },
+      },
+    ],
+    {
+      amount: [
+        {
+          amount: '20000',
+          denom: 'uusdc',
+        },
+      ],
+      gas: '200000',
+    },
+    'Register Account Transaction',
+  ]);
+});


This is a pretty important external interface. Consider using t.snapshot() rather than t.deepEqual(); the snapshot markdown files are particularly useful docs. Plus, they're low maintenance (just run yarn test -u and check the diffs).

packages/fast-usdc/test/cli/transfer.test.ts

packages/fast-usdc/testing/mocks.ts

dckc · 2024-11-13T03:32:41Z

packages/fast-usdc/src/cli/transfer.js

+      { chainName: 'agoric', rpcAddrs: [config.agoricRpc] },
+    );
+    const agoricAddr = await queryFastUSDCLocalChainAccount(vstorage, out);
+    const appendedAddr = `${agoricAddr}+${destination}`;


The + syntax isn't defined by this module, is it? It seems like we should be able to import a function that combines these two.

I suggest making a local function and marking it TODO: update syntax to sync with other components or something.

Are we even still using + syntax? In something linked from Fast USDC Eng Design / Sketch, I see:

❓ How should the parameters be separated from the address?
✓ Use "?" separator
✓ How should the parameters be encoded?
✓ Use URL query param encoding

Fixed, after discussion we're going with ?EUD=, good catch.

packages/fast-usdc/src/cli/transfer.js

dckc · 2024-11-13T04:53:30Z

packages/fast-usdc/test/cli/transfer.test.ts

+  t.deepEqual(mockEthProvider.getTxnArgs()[0], [
+    '0xf8a4800180941c7d4b196cb0c7b01d743fbc6116a902379c723880b844095ea7b30000000000000000000000009f3b8679c73c2fef8b59b4f3444d4e156fb70aa50000000000000000000000000000000000000000000000000000000008f0d18082011aa0b2d87eeb1cb36243f95662739e2a7bd4bddc2b8afe189ac4848ec71cc314335ba068136695c644f69474e2e30ea7059f9b380fbb1a09beb3580f73d3ea349912ab',
+  ]);


I wonder how to review that. I suppose we'll eventually do integration testing, and we'll find out real quick if it's not right at that point.

Meanwhile, I did try to puzzle it out a little, and this form might be slightly more legible. Dunno whether it's really useful, but I'll share it rather than throw it away:

Suggested change

t.deepEqual(mockEthProvider.getTxnArgs()[0], [

'0xf8a4800180941c7d4b196cb0c7b01d743fbc6116a902379c723880b844095ea7b30000000000000000000000009f3b8679c73c2fef8b59b4f3444d4e156fb70aa50000000000000000000000000000000000000000000000000000000008f0d18082011aa0b2d87eeb1cb36243f95662739e2a7bd4bddc2b8afe189ac4848ec71cc314335ba068136695c644f69474e2e30ea7059f9b380fbb1a09beb3580f73d3ea349912ab',

]);

t.deepEqual(ethers.decodeRlp(mockEthProvider.getTxnArgs()[0]), [

'0x',

'0x01',

'0x',

'0x1c7d4b196cb0c7b01d743fbc6116a902379c7238',

'0x',

'0x095ea7b30000000000000000000000009f3b8679c73c2fef8b59b4f3444d4e156fb70aa50000000000000000000000000000000000000000000000000000000008f0d180',

'0x011a',

'0xb2d87eeb1cb36243f95662739e2a7bd4bddc2b8afe189ac4848ec71cc314335b',

'0x68136695c644f69474e2e30ea7059f9b380fbb1a09beb3580f73d3ea349912ab',

]);

Yea I'm not really sure either. Just left a comment because I found a website that can decode it. But I spent a little bit trying to do it myself with ethers and couldn't succeed.

cool. the comment is quite nice.

dckc · 2024-11-13T04:57:10Z

packages/fast-usdc/test/util/file.test.ts

+  t.is(file.path, path);
+});
+
+test('reads the file contents', async t => {


this file of tests for makeFile seems like overkill. Sorry if I suggested otherwise. I suppose they don't hurt much, other than maintenance.

dckc · 2024-11-13T05:07:11Z

packages/fast-usdc/src/cli/cli.js

+  configHelpers = configLib,
+  transferHelpers = transferLib,


is it useful to inject these 2 any more? Don't we just inject fetch and makeSigner and such?

note: ok... I get it... we mock transferHelpers to check that initProgram calls transferHelpers as expected and then unit test transferHelpers such as .transfer. fair enough.

dckc · 2024-11-13T05:14:44Z

packages/fast-usdc/src/cli/transfer.js

+/** @typedef {import('../util/file').file} file */
+/** @typedef {import('@agoric/client-utils').VStorage} VStorage */
+/** @typedef {import('@cosmjs/stargate').SigningStargateClient} SigningStargateClient */
+/** @typedef {import('ethers').ethers.JsonRpcProvider} ethProvider */


suggestion: use @import rather than @typedef. @typedef loses docstrings.

Ooh TIL... done.

dckc · 2024-11-13T05:17:56Z

packages/fast-usdc/src/cli/transfer.js

+const transfer = async (
+  /** @type {file} */ configFile,
+  /** @type {string} */ amount,
+  /** @type {string} */ destination,


The rest of agoric-sdk uses @param. This is more concise in a way, so I don't mind too much. It's also more like typescript, which we seem to be headed toward. So maybe it's better.

Ack, if you don't feel strongly I'll leave as is

LGTM. We might have the whole package on .ts soon: #10480

samsiegart

PTAL

samsiegart · 2024-11-13T19:41:31Z

packages/fast-usdc/src/cli/transfer.js

+/** @typedef {import('../util/file').file} file */
+/** @typedef {import('@agoric/client-utils').VStorage} VStorage */
+/** @typedef {import('@cosmjs/stargate').SigningStargateClient} SigningStargateClient */
+/** @typedef {import('ethers').ethers.JsonRpcProvider} ethProvider */


Ooh TIL... done.

samsiegart · 2024-11-13T19:41:52Z

packages/fast-usdc/src/cli/transfer.js

+const transfer = async (
+  /** @type {file} */ configFile,
+  /** @type {string} */ amount,
+  /** @type {string} */ destination,


Ack, if you don't feel strongly I'll leave as is

samsiegart · 2024-11-13T19:49:55Z

packages/fast-usdc/src/cli/transfer.js

+      { chainName: 'agoric', rpcAddrs: [config.agoricRpc] },
+    );
+    const agoricAddr = await queryFastUSDCLocalChainAccount(vstorage, out);
+    const appendedAddr = `${agoricAddr}+${destination}`;


Fixed, after discussion we're going with ?EUD=, good catch.

packages/fast-usdc/src/cli/transfer.js

samsiegart · 2024-11-13T20:09:12Z

packages/fast-usdc/src/cli/transfer.js

+        out.error(
+          `Error noble registering forwarding account for ${appendedAddr} on channel ${config.nobleToAgoricChannel}`,
+        );
+        return;


No you're right, it shouldn't be considered a success condition. I just went back and made sure all these fatal errors actually throw.

samsiegart · 2024-11-13T20:43:25Z

packages/fast-usdc/test/cli/transfer.test.ts

+  t.deepEqual(signerMock.getSigned(), [
+    nobleSignerAddress,
+    [
+      {
+        typeUrl: '/noble.forwarding.v1.MsgRegisterAccount',
+        value: {
+          channel: nobleToAgoricChannel,
+          recipient: `${agoricSettlementAccount}+${destination}`,
+          signer: nobleSignerAddress,
+        },
+      },
+    ],
+    {
+      amount: [
+        {
+          amount: '20000',
+          denom: 'uusdc',
+        },
+      ],
+      gas: '200000',
+    },
+    'Register Account Transaction',
+  ]);
+});


packages/fast-usdc/test/cli/transfer.test.ts

samsiegart · 2024-11-13T21:08:14Z

packages/fast-usdc/test/cli/transfer.test.ts

+  t.deepEqual(mockEthProvider.getTxnArgs()[0], [
+    '0xf8a4800180941c7d4b196cb0c7b01d743fbc6116a902379c723880b844095ea7b30000000000000000000000009f3b8679c73c2fef8b59b4f3444d4e156fb70aa50000000000000000000000000000000000000000000000000000000008f0d18082011aa0b2d87eeb1cb36243f95662739e2a7bd4bddc2b8afe189ac4848ec71cc314335ba068136695c644f69474e2e30ea7059f9b380fbb1a09beb3580f73d3ea349912ab',
+  ]);


Yea I'm not really sure either. Just left a comment because I found a website that can decode it. But I spent a little bit trying to do it myself with ethers and couldn't succeed.

samsiegart · 2024-11-13T21:08:45Z

packages/fast-usdc/test/util/file.test.ts

+  t.is(file.path, path);
+});
+
+test('reads the file contents', async t => {


packages/fast-usdc/testing/mocks.ts

dckc · 2024-11-13T21:38:41Z

packages/fast-usdc/src/cli/transfer.js

@@ -32,7 +32,7 @@ const transfer = async (
      { chainName: 'agoric', rpcAddrs: [config.agoricRpc] },
    );
    const agoricAddr = await queryFastUSDCLocalChainAccount(vstorage, out);
-    const appendedAddr = `${agoricAddr}+${destination}`;
+    const appendedAddr = `${agoricAddr}?EUD=${destination}`;


This implementation assumes destination doesn't need URL encoding. I suppose that's true for any correct bech32 addresses. But I'm not sure we validate that destination is a correct bech32 address.

packages/fast-usdc/src/utils/address.js has some addressTools. I wonder if a function there to combine these is worthwhile. I'm OK postponing until the need is more evident.

I had to fix this anyway. It will now encode all of appendedAddr, which I think should work regardless.

dckc · 2024-11-13T21:40:34Z

packages/fast-usdc/src/util/noble.js

+  /**
+   * https://github.com/noble-assets/forwarding/blob/9d7657a/proto/noble/forwarding/v1/query.proto
+   * v2.0.0 10 Nov 2024
+   */


I meant a docstring on queryForwardingAccount. sorry i wasn't clear. not critical.

I would but then it makes me pull all the args into the docstring as well, quite annoying

oh... if using @type rather than @param means no prose docstrings, that's going to be a problem real soon.

dckc

samsiegart · 2024-11-13T21:51:34Z

Logs from a successful run after updating the URL encoding (ignore the insufficient funds thing, that's just because my eth account was empty. Also, the "agoric1234asdadfga" address was stubbed before running):

$ fast-usdc transfer 0.25 dydx1234 --home=demo/testnet/
forwarding destination agoric1234asdadfga?EUD=dydx1234
querying forward address details from noble api: https://noble-api.polkachu.com/noble/forwarding/v1/address/channel-21/agoric1234asdadfga%3FEUD%3Ddydx1234/
got forwarding address details: {"address":"noble1s7jcagjg34z9ucrfhkcg9t880ttksjsrgs8amq","exists":false}
got noble wallet from seed
registering fwd account on noble
signing message Object <[Object: null prototype] {}> {
  typeUrl: '/noble.forwarding.v1.MsgRegisterAccount',
  value: Object <[Object: null prototype] {}> {
    signer: 'noble1n4mqetruv26lm2frkjah86h642ts84qy9hfyuv',
    recipient: 'agoric1234asdadfga?EUD=dydx1234',
    channel: 'channel-21'
  }
}
Transaction successful with hash: 5E06175CFEE6B053467B458FAE07037375710849F44F75FD3586D07A2B726A92
approving
SES_UNHANDLED_REJECTION: (Error#1)
Error#1: insufficient funds for intrinsic transaction cost (transaction="0x02f8b183aa36a7058310528484139136b482da0b941c7d4b196cb0c7b01d743fbc6116a902379c723880b844095ea7b30000000000000000000000009f3b8679c73c2fef8b59b4f3444d4e156fb70aa5000000000000000000000000000000000000000000000000000000000003d090c080a029509d5664e90049a836cba1a1213910ecc2c117f079b4382f0cc01b310bd609a05a2c351e7876fbf829afb5d5ee27c9f27c9b743048675db84d1b08e553c589bd", info={ "error": { "code": -32000, "message": "INTERNAL_ERROR: insufficient funds" } }, code=INSUFFICIENT_FUNDS, version=6.13.4)
  at makeError (file:///home/samsiegart/agoric-sdk/node_modules/ethers/lib.esm/utils/errors.js:124:21)
  at JsonRpcProvider.getRpcError (file:///home/samsiegart/agoric-sdk/node_modules/ethers/lib.esm/providers/provider-jsonrpc.js:698:24)
  at file:///home/samsiegart/agoric-sdk/node_modules/ethers/lib.esm/providers/provider-jsonrpc.js:298:45
  at process.processTicksAndRejections (node:internal/process/task_queues:95:5)

samsiegart force-pushed the srs-fu-cli branch from cdc9d32 to 04f8e3f Compare November 11, 2024 18:45

samsiegart requested a review from dckc November 11, 2024 18:51

samsiegart marked this pull request as ready for review November 11, 2024 19:07

samsiegart requested a review from a team as a code owner November 11, 2024 19:07

dckc reviewed Nov 12, 2024

View reviewed changes

packages/fast-usdc/src/util/cctp.js Outdated Show resolved Hide resolved

packages/fast-usdc/src/util/agoric.js Outdated Show resolved Hide resolved

samsiegart force-pushed the srs-fu-cli branch from 14de6d4 to 971aa7b Compare November 12, 2024 19:16

dckc reviewed Nov 12, 2024

View reviewed changes

packages/fast-usdc/src/util/noble.js Outdated Show resolved Hide resolved

dckc reviewed Nov 12, 2024

View reviewed changes

samsiegart requested a review from dckc November 12, 2024 23:05

samsiegart force-pushed the srs-fu-cli branch from d60b4da to bc4554d Compare November 13, 2024 01:11

dckc requested changes Nov 13, 2024

View reviewed changes

samsiegart commented Nov 13, 2024

View reviewed changes

samsiegart requested a review from dckc November 13, 2024 21:15

dckc reviewed Nov 13, 2024

View reviewed changes

dckc approved these changes Nov 13, 2024

View reviewed changes

samsiegart added the automerge:rebase Automatically rebase updates, then merge label Nov 13, 2024

samsiegart force-pushed the srs-fu-cli branch 2 times, most recently from 501ee86 to 98d08f3 Compare November 14, 2024 00:55

samsiegart added 3 commits November 14, 2024 04:28

feat(fast-usdc): stub transfer cli command

1b64d82

feat(fast-usdc): stub config cli command

81e14b2

feat(fast-usdc): implement config cli command

d121e1d

samsiegart added 9 commits November 14, 2024 04:28

feat(fast-usdc): implement transfer cli command

504818f

refactor(fast-usdc): use file objects rather than paths

f0f76db

test(fast-usdc): test cli transfer

cac96bb

chore(fast-usdc): use import rather than typedef

9b06146

fix(fast-usdc): use correct address format in cli

d225974

fix(fast-usdc): ensure cli non-zero exit code on failure

6c0e77b

chore(fast-usdc): docs and hardening

992a56d

chore(fast-usdc): add type to util fn

52033cf

fix(fast-usdc): fix url encoding

d46cefd

samsiegart force-pushed the srs-fu-cli branch from 98d08f3 to d46cefd Compare November 14, 2024 04:28

mergify bot merged commit 511b789 into master Nov 14, 2024
81 checks passed

mergify bot deleted the srs-fu-cli branch November 14, 2024 06:39

		const clientWithSigner = await SigningStargateClient.connectWithSigner(
		nobleRpc,

		const makeConfigFile = () =>
		makeFile(getConfigPath(), readFile, writeFile, mkdir, exists);

-  t.deepEqual(mockEthProvider.getTxnArgs()[0], [
-    '0xf8a4800180941c7d4b196cb0c7b01d743fbc6116a902379c723880b844095ea7b30000000000000000000000009f3b8679c73c2fef8b59b4f3444d4e156fb70aa50000000000000000000000000000000000000000000000000000000008f0d18082011aa0b2d87eeb1cb36243f95662739e2a7bd4bddc2b8afe189ac4848ec71cc314335ba068136695c644f69474e2e30ea7059f9b380fbb1a09beb3580f73d3ea349912ab',
-  ]);
+  t.deepEqual(ethers.decodeRlp(mockEthProvider.getTxnArgs()[0]), [
+    '0x',
+    '0x01',
+    '0x',
+    '0x1c7d4b196cb0c7b01d743fbc6116a902379c7238',
+    '0x',
+    '0x095ea7b30000000000000000000000009f3b8679c73c2fef8b59b4f3444d4e156fb70aa50000000000000000000000000000000000000000000000000000000008f0d180',
+    '0x011a',
+    '0xb2d87eeb1cb36243f95662739e2a7bd4bddc2b8afe189ac4848ec71cc314335b',
+    '0x68136695c644f69474e2e30ea7059f9b380fbb1a09beb3580f73d3ea349912ab',
+  ]);

Fast USDC CLI: Transfer #10437

Fast USDC CLI: Transfer #10437

Conversation

samsiegart commented Nov 9, 2024 • edited Loading

Description

Documentation Considerations

Testing Considerations

Upgrade Considerations

cloudflare-workers-and-pages bot commented Nov 9, 2024 • edited Loading

Deploying agoric-sdk with Cloudflare Pages

dckc commented Nov 12, 2024

samsiegart commented Nov 12, 2024 • edited Loading

dckc left a comment

Choose a reason for hiding this comment

dckc commented Nov 12, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

samsiegart Nov 12, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

samsiegart commented Nov 12, 2024

dckc left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

samsiegart left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

dckc Nov 13, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

dckc left a comment

Choose a reason for hiding this comment

samsiegart commented Nov 13, 2024 • edited Loading

samsiegart commented Nov 9, 2024 •

edited

Loading

cloudflare-workers-and-pages bot commented Nov 9, 2024 •

edited

Loading

samsiegart commented Nov 12, 2024 •

edited

Loading

samsiegart Nov 12, 2024 •

edited

Loading

dckc Nov 13, 2024 •

edited

Loading

samsiegart commented Nov 13, 2024 •

edited

Loading