Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

config structure #745

Draft
wants to merge 16 commits into
base: main
Choose a base branch
from
Draft

config structure #745

wants to merge 16 commits into from

Conversation

frederik-uni
Copy link

@frederik-uni frederik-uni commented Nov 16, 2024

the args are too messed up. There are way too many options. that's why I converted it to a class structure. Instead of having tons of arguments it would make more sense to have a config file for everything. it's not loaded anywhere so its just the structure. the code would need to be changed a bit, but not much. it also adds typesafty

@frederik-uni frederik-uni marked this pull request as draft November 16, 2024 22:18
@frederik-uni
Copy link
Author

frederik-uni commented Nov 16, 2024

@zyddnys
Where should these args be placed in the structure?

    """Set the convolution kernel size of the text erasure area to completely clean up text residues"""
    kernel_size: int = 3
    """By how much to extend the text mask to remove left-over text pixels of the original image."""
    mask_dilation_offset: int = 0

@frederik-uni
Copy link
Author

oh and which file extension should the config have? toml, yml, json?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant