Switch execution order of scrub_items() and prune_news() #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rationale was that cache scrub would reduce number of items to iterate through later. However, if expiration hasn't been updated in "long" time eg. due to error or low traffic(HTTP Staus Code 304), then the whole cache gets invalidated which leads to excess flood. One solution is to increase cache expiration(in other words one day is really low). Another solution seems to be to switch order of execution, because prune_news() updates time of expiration. Therefore, it should prevent scrubbing of news which are still present in RSS feed. And it's also possible there is a bug somewhere in the code.
zstyblik
force-pushed
the
switch_scrub_prune
branch
from
eadf83f to
501068a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale was that cache scrub would reduce number of items to iterate through later. However, if expiration hasn't been updated in "long" time eg. due to error or low traffic(HTTP Staus Code 304), then the whole cache gets invalidated which leads to excess flood.
One solution is to increase cache expiration(in other words one day is really low).
Another solution seems to be to switch order of execution, because prune_news() updates time of expiration. Therefore, it should prevent scrubbing of news which are still present in RSS feed. And it's also possible there is a bug somewhere in the code.