Cleanup shell and fix two bugs related to "in" pipes #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
... somewhere along the way, I've either missed this or checkbashism did.
It might(and it did) happen that channel's "in" wasn't pipe, but file. This might be because something is "stale", ii got killed and couldn't cleanup or bug in iibot-ng. We do this with main "in" pipe(file), I see no reason why we couldn't do it for channels as well.
Commit increases wait-on-connection time from 15 to 60 seconds. Also, if we didn't get "in" pipe after 60 seconds, exit. Because if we don't exit, we end up with files instead of pipes. It's possible that wait-on-connection timeout will have to be adjusted further.
zstyblik
force-pushed
the
fix_improve_comment
branch
from
d56f0b9 to
a0a07df
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.